Skip to content

Commit 34ffd84

Browse files
fix: Fix regression in v0.52.0 where the auth attribute was removed from the RESTStream.requests_session instance (#3343)
* fix: Fix regression in v0.52.0 where the `auth` attribute was removed from the `RESTStream.requests_session` instance * Fix tests
1 parent ffd9a81 commit 34ffd84

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

singer_sdk/streams/rest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,7 @@ def build_prepared_request(
393393
A :class:`requests.PreparedRequest` object.
394394
"""
395395
request = requests.Request(*args, **kwargs)
396+
self.requests_session.auth = self.authenticator
396397
return self.requests_session.prepare_request(request)
397398

398399
def prepare_request(

tests/core/rest/test_authenticators.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -277,8 +277,6 @@ def test_requests_library_auth(rest_tap: Tap):
277277
"""Validate that a requests.auth object can be used as an authenticator."""
278278
stream = t.cast("RESTStream", rest_tap.streams["proxy_auth_stream"])
279279
request = stream.prepare_request(None, None)
280-
assert "Proxy-Authorization" not in request.headers
281-
282280
authenticated_request = stream.authenticator(request)
283281
assert "Proxy-Authorization" in authenticated_request.headers
284282

@@ -590,8 +588,8 @@ def backoff_jitter(self, value: float) -> float:
590588
# Verify the request succeeded
591589
assert records == [{"id": 1}]
592590

593-
# Verify authenticator was called 3 times (initial + 2 retries)
594-
assert auth_call_count == 3
591+
# Verify authenticator was called 4 times (setup + initial + 2 retries)
592+
assert auth_call_count == 4
595593

596594
assert len(caplog.records) == 2
597595
assert all(rec.levelname == "ERROR" for rec in caplog.records)

0 commit comments

Comments
 (0)