[X86] avx512fp16intrin.h - allow _mm512_set1_pch to be used in constexpr (llvm#162245)

RKSimon · web-flow · commit fddd1b60fdf0 · 2025-10-07T09:24:56.000Z
This was missed in the earlier fp16 constexpr patches for _mm_set1_pch/_mm256_set1_pch
diff --git a/clang/lib/Headers/avx512fp16intrin.h b/clang/lib/Headers/avx512fp16intrin.h
@@ -112,7 +112,7 @@ static __inline__ __m512h __DEFAULT_FN_ATTRS512_CONSTEXPR _mm512_setr_ph(
                        e9, e8, e7, e6, e5, e4, e3, e2, e1, e0);
 }
 
-static __inline __m512h __DEFAULT_FN_ATTRS512
+static __inline __m512h __DEFAULT_FN_ATTRS512_CONSTEXPR
 _mm512_set1_pch(_Float16 _Complex __h) {
   return (__m512h)_mm512_set1_ps(__builtin_bit_cast(float, __h));
 }
diff --git a/clang/test/CodeGen/X86/avx512fp16-builtins.c b/clang/test/CodeGen/X86/avx512fp16-builtins.c
@@ -117,6 +117,7 @@ __m512h test_mm512_set1_pch(_Float16 _Complex h) {
   // CHECK: bitcast <16 x float>{{.*}} to <32 x half>
   return _mm512_set1_pch(h);
 }
+TEST_CONSTEXPR(match_m512h(_mm512_set1_pch(1.0), 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0));
 
 __m512h test_mm512_set_ph(_Float16 __h1, _Float16 __h2, _Float16 __h3, _Float16 __h4,
                           _Float16 __h5, _Float16 __h6, _Float16 __h7, _Float16 __h8,

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ static __inline__ __m512h __DEFAULT_FN_ATTRS512_CONSTEXPR _mm512_setr_ph(`
`112`	`112`	`e9, e8, e7, e6, e5, e4, e3, e2, e1, e0);`
`113`	`113`	`}`
`114`	`114`
`115`		`-static __inline __m512h __DEFAULT_FN_ATTRS512`
	`115`	`+static __inline __m512h __DEFAULT_FN_ATTRS512_CONSTEXPR`
`116`	`116`	`_mm512_set1_pch(_Float16 _Complex __h) {`
`117`	`117`	`return (__m512h)_mm512_set1_ps(__builtin_bit_cast(float, __h));`
`118`	`118`	`}`
Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,7 @@ __m512h test_mm512_set1_pch(_Float16 _Complex h) {`
`117`	`117`	`// CHECK: bitcast <16 x float>{{.*}} to <32 x half>`
`118`	`118`	`return _mm512_set1_pch(h);`
`119`	`119`	`}`
	`120`	`+TEST_CONSTEXPR(match_m512h(_mm512_set1_pch(1.0), 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0, 1.0, 0.0));`
`120`	`121`
`121`	`122`	`__m512h test_mm512_set_ph(_Float16 __h1, _Float16 __h2, _Float16 __h3, _Float16 __h4,`
`122`	`123`	`_Float16 __h5, _Float16 __h6, _Float16 __h7, _Float16 __h8,`