Body: Potential Leaking of Input Stream

[predic8]

Looks like body.getStream... returns a new Stream from Chunk bytes. Then the caller should close inputStrem. Do not know if this is always the case.

One place that is affected:

InputStream leak when formatting/copying body (formatXML no longer closes it)

Since TextUtil.formatXML(InputStream, ...) intentionally does not close the provided stream (good), the InputStreams obtained via body.getContentAsStream() must be closed here. Wrap them in try-with-resources to prevent descriptor/memory leaks under load.

Apply this diff:

 try (FileOutputStream os = new FileOutputStream(file)) {
     if (raw || !saveBodyOnly) {
         msg.writeStartLine(os);
         msg.getHeader().write(os);
         os.write(Constants.CRLF_BYTES);
     }

     if (raw) {
-        IOUtils.copy(body.getContentAsStream(), os);
+        try (InputStream in = body.getContentAsStream()) {
+            IOUtils.copy(in, os);
+        }
     } else {
         if (msg.isXML()) {
-            os.write(formatXML(body.getContentAsStream(), /*asHTML*/ false).getBytes(UTF_8));
-            return;
+            try (InputStream in = body.getContentAsStream()) {
+                os.write(formatXML(in, /*asHTML*/ false).getBytes(UTF_8));
+            }
+            return; // os closed by outer TWR
         }
-        IOUtils.copy(body.getContentAsStream(), os);
+        try (InputStream in = body.getContentAsStream()) {
+            IOUtils.copy(in, os);
+        }
     }
 }
 

[predic8]

	public InputStream getContentAsStream() throws IOException {
		if (wasStreamed)
			throw new IllegalStateException("Cannot read body after it was streamed.");
		read();
		return new BodyInputStream(chunks);
	}

[rrayst]

body.getContentAsStream().close() is a no-op.