Apply review

Author: FelonEkonom

lib/membrane_http_adaptive_stream/source.ex

@@ -107,7 +107,7 @@ defmodule Membrane.HTTPAdaptiveStream.Source do
                 description: """
                 Specifies how much time should be discarded from each of the tracks.
 
-                Please note that an actual discarded part of the stream might will be at most of that length
+                Please note that an actual discarded part of the stream might be at most of that length
                 because it needs to be aligned with HLS segments distribution.
                 The source will send an `Membrane.Event.Discontinuity` event with `:duration` field
                 representing duration of the discarded part of the stream.
@@ -230,13 +230,7 @@ defmodule Membrane.HTTPAdaptiveStream.Source do
   defp start_streaming(%{status: status} = state)
        when status in [:initialized, :waiting_on_pads] do
     actions = get_stream_formats(state) ++ get_redemands(state)
-
-    state = %{
-      state
-      | status: :streaming
-        # stream: Client.generate_stream(state.client_genserver)
-    }
-
+    state = %{state | status: :streaming}
     {actions, state}
   end
 
@@ -326,7 +320,7 @@ defmodule Membrane.HTTPAdaptiveStream.Source do
 
   defp get_discontinuity_events(%{initial_discontinuity_event_sent?: false} = state) do
     skipped_segments_cumulative_duration =
-      ClientGenServer.get_skipped_segments_cumulative_duration_ms(state.client_genserver)
+      ClientGenServer.get_skipped_segments_cumulative_duration(state.client_genserver)
 
     event = %Membrane.Event.Discontinuity{duration: skipped_segments_cumulative_duration}
 

lib/membrane_http_adaptive_stream/source/client_genserver.ex

@@ -32,10 +32,9 @@ defmodule Membrane.HTTPAdaptiveStream.Source.ClientGenServer do
     GenServer.cast(client_genserver, {:request_chunk_or_eos, self()})
   end
 
-  @spec get_skipped_segments_cumulative_duration_ms(pid()) ::
-          {:ok, Membrane.Time.t()} | {:error, reason :: any()}
-  def get_skipped_segments_cumulative_duration_ms(client_genserver) do
-    GenServer.call(client_genserver, :get_skipped_segments_cumulative_duration_ms)
+  @spec get_skipped_segments_cumulative_duration(pid()) :: Membrane.Time.t()
+  def get_skipped_segments_cumulative_duration(client_genserver) do
+    GenServer.call(client_genserver, :get_skipped_segments_cumulative_duration)
   end
 
   # this function should be called by Membrane.HTTPAdaptiveStream.Source
@@ -140,7 +139,7 @@ defmodule Membrane.HTTPAdaptiveStream.Source.ClientGenServer do
   end
 
   @impl true
-  def handle_call(:get_skipped_segments_cumulative_duration_ms, _from, state) do
+  def handle_call(:get_skipped_segments_cumulative_duration, _from, state) do
     {:ok, skipped_duration_ms} =
       Client.get_skipped_segments_cumulative_duration_ms(state.client)