Skip to content

Commit 58913e4

Browse files
committed
Implement CR comments
1 parent c81c07d commit 58913e4

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lib/membrane_http_adaptive_stream/source.ex

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,6 @@ defmodule Membrane.HTTPAdaptiveStream.Source do
136136
{:ok, client_genserver} =
137137
ClientGenServer.start_link(state.url, state.variant_selection_policy)
138138

139-
# todo: maybe we should call here `get_tracks_info/1` to start downloading segments
140-
# or we should start buffering frames?
141-
142139
{[], %{state | client_genserver: client_genserver}}
143140
end
144141

@@ -175,6 +172,10 @@ defmodule Membrane.HTTPAdaptiveStream.Source do
175172

176173
@impl true
177174
def handle_playing(_ctx, state) do
175+
# both start_running/1 and generate_new_tracks_notification/1 functions
176+
# call ClientGenServer.get_tracks_info/1 that triggers downloading first
177+
# segments of the HLS stream
178+
178179
if state.audio_output.ref != nil or state.video_output.ref != nil do
179180
state |> start_running()
180181
else

0 commit comments

Comments
 (0)