Bump to v0.29.0. Make reset_timestamps disabled by default. Add connect_in_advance option

Author: varsill

README.md

@@ -14,7 +14,7 @@ The package can be installed by adding `membrane_rtmp_plugin` to your list of de
 ```elixir
 def deps do
   [
-	  {:membrane_rtmp_plugin, "~> 0.28.1"}
+	  {:membrane_rtmp_plugin, "~> 0.29.0"}
   ]
 end
 ```

lib/membrane_rtmp_plugin/rtmp/sink/sink.ex

@@ -55,11 +55,19 @@ defmodule Membrane.RTMP.Sink do
               ],
               reset_timestamps: [
                 spec: boolean(),
-                default: true,
+                default: false,
                 description: """
                 If enabled, this feature adjusts the timing of outgoing FLV packets so that they begin from zero.
                 Leaves it untouched otherwise.
                 """
+              ],
+              connect_in_advance: [
+                spec: boolean(),
+                default: true,
+                description: """
+                If enabled, the Sink will connect to the server during the element setup.
+                Otherwise, the connection will be made when stream data is already available in the element.
+                """
               ]
 
   @impl true
@@ -105,23 +113,41 @@ defmodule Membrane.RTMP.Sink do
   end
 
   @impl true
-  def handle_setup(_ctx, state) do
-    audio? = :audio in state.tracks
-    video? = :video in state.tracks
-
-    {:ok, native} = Native.create(state.rtmp_url, audio?, video?)
+  def handle_setup(_ctx, %{connect_in_advance: true} = state) do
+    initialize_native(state)
+  end
 
-    state
-    |> Map.put(:native, native)
-    |> try_connect()
-    |> then(&{[], &1})
+  @impl true
+  def handle_setup(_ctx, state) do
+    {[], state}
   end
 
   @impl true
   def handle_playing(_ctx, state) do
     {build_demand(state), state}
   end
 
+  @impl true
+  def handle_start_of_stream(_pad, ctx, %{connect_in_advance: false} = state) do
+    all_pads_connected? =
+      Enum.all?(state.tracks, fn track ->
+        Enum.any?(ctx.pads, fn
+          {Pad.ref(^track, _ref), pad} ->
+            pad.start_of_stream?
+
+          _other ->
+            false
+        end)
+      end)
+
+    if all_pads_connected?, do: initialize_native(state), else: {[], state}
+  end
+
+  @impl true
+  def handle_start_of_stream(_pad, _ctx, state) do
+    {[], state}
+  end
+
   @impl true
   def handle_pad_added(Pad.ref(_type, stream_id), _ctx, _state) when stream_id != 0,
     do: raise(ArgumentError, message: "Stream id must always be 0")
@@ -348,4 +374,16 @@ defmodule Membrane.RTMP.Sink do
     {base_dts, state} = Bunch.Map.get_updated!(state, :video_base_dts, &(&1 || dts))
     {{dts - base_dts, pts - base_dts}, state}
   end
+
+  defp initialize_native(state) do
+    audio? = :audio in state.tracks
+    video? = :video in state.tracks
+
+    {:ok, native} = Native.create(state.rtmp_url, audio?, video?)
+
+    state
+    |> Map.put(:native, native)
+    |> try_connect()
+    |> then(&{[], &1})
+  end
 end

mix.exs

@@ -1,7 +1,7 @@
 defmodule Membrane.RTMP.Mixfile do
   use Mix.Project
 
-  @version "0.28.1"
+  @version "0.29.0"
   @github_url "https://github.com/membraneframework/membrane_rtmp_plugin"
 
   def project do