Memfault Firmware SDK 1.11.4 (Build local)

Author: Memfault Inc.

CHANGELOG.md

@@ -6,6 +6,27 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.11.4] - 2024-09-10
+
+### :chart_with_upwards_trend: Improvements
+
+- ESP-IDF:
+
+  - Fix a minor issue where `MEMFAULT_LOG_x()` macros (`MEMFAULT_LOG_ERROR()`
+    etc ) would be recorded twice in the log buffer.
+
+- General:
+
+  - Fix an error in the unit test CI build due to the addition of the
+    `-Wc11-c2x-compat` compiler warning flag. This flag is not valid for the C++
+    compiler, and has been changed to be enabled only for the C compiler.
+
+- nRF-Connect SDK:
+
+  - Fix a possible stack overflow when tracking the Memfault Connectivity
+    Connected Time Vital for the nRF9160 LTE connection, due to a change in the
+    nRF-Connect SDK v2.7.0 from prior versions.
+
 ## [1.11.3] - 2024-09-05
 
 ### :chart_with_upwards_trend: Improvements

VERSION

@@ -1,3 +1,3 @@
 BUILD ID: local
-GIT COMMIT: c29972dd3ef
-VERSION: 1.11.3
+GIT COMMIT: a3e5d59615c
+VERSION: 1.11.4

components/demo/src/memfault_demo_cli_log.c

@@ -20,9 +20,10 @@ int memfault_demo_cli_cmd_test_log(MEMFAULT_UNUSED int argc, MEMFAULT_UNUSED cha
   MEMFAULT_LOG_WARN("Warning log!");
   MEMFAULT_LOG_ERROR("Error log!");
 
-#if MEMFAULT_SDK_LOG_SAVE_DISABLE
+  // ESP-IDF will still save logs when MEMFAULT_SDK_LOG_SAVE_DISABLE is set
+#if MEMFAULT_SDK_LOG_SAVE_DISABLE && !defined(ESP_PLATFORM)
   // MEMFAULT_LOGs are not written to the ram backed log buffer so do
-  // it explicitly
+  // it explicitly for testing purposes
   MEMFAULT_LOG_SAVE(kMemfaultPlatformLogLevel_Debug, "Debug log!");
   MEMFAULT_LOG_SAVE(kMemfaultPlatformLogLevel_Info, "Info log!");
   MEMFAULT_LOG_SAVE(kMemfaultPlatformLogLevel_Warning, "Warning log!");

components/include/memfault/version.h

@@ -19,8 +19,8 @@ typedef struct {
   uint8_t patch;
 } sMfltSdkVersion;
 
-#define MEMFAULT_SDK_VERSION   { .major = 1, .minor = 11, .patch = 3 }
-#define MEMFAULT_SDK_VERSION_STR "1.11.3"
+#define MEMFAULT_SDK_VERSION   { .major = 1, .minor = 11, .patch = 4 }
+#define MEMFAULT_SDK_VERSION_STR "1.11.4"
 
 #ifdef __cplusplus
 }

ports/esp_idf/memfault/config/memfault_esp_idf_port_config.h

@@ -59,6 +59,10 @@ extern "C" {
   #define MEMFAULT_COMPACT_LOG_ENABLE 1
 #endif
 
+// Memfault SDK logs are routed to ESP-IDF logging, which are saved by Memfault,
+// so it's redundant to save them in the Memfault SDK as well.
+#define MEMFAULT_SDK_LOG_SAVE_DISABLE 1
+
 // Pick up any user configuration overrides. This should be kept at the bottom
 // of this file
 #if CONFIG_MEMFAULT_USER_CONFIG_SILENT_FAIL

ports/zephyr/ncs/src/memfault_platform_metrics_connectivity_lte.c

@@ -24,10 +24,6 @@
 #if defined(CONFIG_MEMFAULT_NRF_CONNECTIVITY_CONNECTED_TIME_NRF91X)
 //! Handler for LTE events
 static void prv_memfault_lte_event_handler(const struct lte_lc_evt *const evt) {
-  enum lte_lc_func_mode mode;
-  lte_lc_func_mode_get(&mode);
-  MEMFAULT_LOG_DEBUG("LTE mode: %d", mode);
-
   switch (evt->type) {
     case LTE_LC_EVT_NW_REG_STATUS:
       switch (evt->nw_reg_status) {
@@ -47,12 +43,9 @@ static void prv_memfault_lte_event_handler(const struct lte_lc_evt *const evt) {
         case LTE_LC_NW_REG_UNKNOWN:
           // intentional fallthrough
         case LTE_LC_NW_REG_UICC_FAIL:
-          // only mark as disconnected if modem is supposed to be connected
-          if (mode == LTE_LC_FUNC_MODE_NORMAL || mode == LTE_LC_FUNC_MODE_ACTIVATE_LTE) {
-            MEMFAULT_LOG_DEBUG("Connected state: connection lost");
-            memfault_metrics_connectivity_connected_state_change(
-              kMemfaultMetricsConnectivityState_ConnectionLost);
-          }
+          MEMFAULT_LOG_DEBUG("Connected state: connection lost");
+          memfault_metrics_connectivity_connected_state_change(
+            kMemfaultMetricsConnectivityState_ConnectionLost);
           break;
         default:
           break;

scripts/create_arduino_library.py

@@ -56,7 +56,7 @@ def download_memfault_library(working_dir: str, tag: str):
 
 def extract_memfault_library(working_dir: str, release_artifact_filepath: str):
     logging.debug("Extracting %s", release_artifact_filepath)
-    download = tarfile.open(release_artifact_filepath)
+    download = tarfile.open(release_artifact_filepath)  # noqa: SIM115
     download.extractall(working_dir)  # noqa: S202
     root_folder_name = download.getnames()[0]
     download.close()

tests/MakefileWorkerOverrides.mk

@@ -54,6 +54,10 @@ CPPUTEST_WARNINGFLAGS = \
   -Wshadow \
   -Wswitch-default
 
+# Default from MakefileWorker.mk if none defined
+CPPUTEST_C_WARNINGFLAGS = \
+  -Wstrict-prototypes
+
 CPPUTEST_CFLAGS += \
   -Wbad-function-cast
 
@@ -67,7 +71,7 @@ CPPUTEST_WARNINGFLAGS += \
 CC_VERSION_OUTPUT ="$(shell $(CXX) -v 2>&1)"
 CLANG_STR = clang
 ifeq ($(findstring $(CLANG_STR),$(CC_VERSION_OUTPUT)),$(CLANG_STR))
-# Clang-only warning flags
+# Clang-only C/C++ warning flags
 COMPILER_SPECIFIC_WARNINGS += \
   -Wno-bad-function-cast \
   -Wno-c++11-extensions \
@@ -96,15 +100,19 @@ COMPILER_SPECIFIC_WARNINGS += \
   -Wno-zero-length-array \
   -Wno-unsafe-buffer-usage \
   -Wno-cast-function-type-strict \
-  -Wc23-extensions \
+
+# Clang-only C-only warning flags
+COMPILER_SPECIFIC_C_WARNINGS += -Wc23-extensions
 
 else
-# GCC-only warnings
+# GCC-only C/C++ warnings
 COMPILER_SPECIFIC_WARNINGS += \
   -Wformat-signedness \
   -fno-extended-identifiers \
   -Wbidi-chars \
-  -Wc11-c2x-compat \
+
+# GCC-only C-only warnings
+COMPILER_SPECIFIC_C_WARNINGS += -Wc11-c2x-compat
 
 # Only enable -fanalyzer if GCC version is >= 12
 GCC_VERSION_GTEQ_12 := $(shell expr $$($(CC) -dumpversion | cut -f1 -d.) \>= 12)
@@ -141,8 +149,10 @@ CPPUTEST_LDFLAGS += \
 endif
 
 CPPUTEST_WARNINGFLAGS += $(COMPILER_SPECIFIC_WARNINGS)
+CPPUTEST_C_WARNINGFLAGS += $(COMPILER_SPECIFIC_C_WARNINGS)
 
 export CPPUTEST_WARNINGFLAGS
+export CPPUTEST_C_WARNINGFLAGS
 
 export CPPUTEST_LDFLAGS