[gui]

Removing fields from multi filters now works
field string for multi filter is now cleared

Author: mendelsshop

function-grep/src/filter.rs

@@ -1,4 +1,6 @@
-use general_filters::{FunctionInImpl, FunctionInLines, FunctionWithParameterRust};
+use general_filters::{
+    FunctionInImpl, FunctionInLines, FunctionWithParameterPython, FunctionWithParameterRust,
+};
 use std::{
     collections::{hash_map, HashMap},
     fmt::{self, Display},
@@ -335,10 +337,18 @@ impl Filters<'static> {
                         .to_string(),
                     SingleOrMany::Many(Many {
                         name: "function_with_parameter".to_string(),
-                        filters: HashMap::from([(
-                            FunctionWithParameterRust.supports().0,
-                            &FunctionWithParameterRust as &'static dyn Filter<Supports = Language>,
-                        )]),
+                        filters: HashMap::from([
+                            (
+                                FunctionWithParameterRust.supports().0,
+                                &FunctionWithParameterRust
+                                    as &'static dyn Filter<Supports = Language>,
+                            ),
+                            (
+                                FunctionWithParameterPython.supports().0,
+                                &FunctionWithParameterPython
+                                    as &'static dyn Filter<Supports = Language>,
+                            ),
+                        ]),
                     }),
                 ),
             ]),

function-grep/src/filter/general_filters.rs

@@ -113,6 +113,7 @@ impl HasFilterInformation for FunctionInImpl {
 }
 
 pub struct FunctionWithParameterRust;
+pub struct FunctionWithParameterPython;
 
 impl HasFilterInformation for FunctionWithParameterRust {
     fn filter_name(&self) -> String {
@@ -139,3 +140,29 @@ impl Filter for FunctionWithParameterRust {
         todo!()
     }
 }
+
+impl HasFilterInformation for FunctionWithParameterPython {
+    fn filter_name(&self) -> String {
+        "function_with_parameter".to_string()
+    }
+
+    fn description(&self) -> String {
+        "Find a function with a given parameter".to_string()
+    }
+
+    fn supports(&self) -> Self::Supports {
+        Language("Python".to_owned())
+    }
+
+    fn attributes(&self) -> Attributes {
+        HashMap::from([(Attribute("Name".to_string()), AttributeType::String)])
+    }
+
+    type Supports = Language;
+}
+
+impl Filter for FunctionWithParameterPython {
+    fn parse_filter(&self, s: &str) -> Result<FilterFunction, String> {
+        todo!()
+    }
+}

git-function-history-gui/src/lib.rs

@@ -277,7 +277,9 @@ impl MyEguiApp {
         let resp = ui.add(Button::new("add field"));
         if resp.clicked() {
             inputs.insert(next_field.to_string(), (false, String::new()));
+            next_field.clear();
         }
+        inputs.retain(|_, input| !input.0);
         egui::ComboBox::from_id_source("filter_language_chooser")
             .selected_text("Language")
             .show_ui(ui, |ui| {