Skip to content

Commit 67fbd38

Browse files
Merge pull request #174 from mendix/revert-165-moo/notifee-migration
Revert "feat: Migrate from react-native-push-notification to @notifee/react-n…"
2 parents d8ea64e + e861071 commit 67fbd38

File tree

12 files changed

+90
-42
lines changed

12 files changed

+90
-42
lines changed

CHANGELOG.android.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
- We have migrated from react-native-push-notification to @notifee/react-native for better new architecture compatibility and enhanced push notification features.
2-
- We fixed an issue where TextInput-based fields like the TextBox and TextArea would not receive focus on Android devices via touch.
1+
- We have improved the UI for users who use three-button navigation when edge-to-edge mode is enabled.

CHANGELOG.ios.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
- We have migrated from react-native-push-notification to @notifee/react-native for better new architecture compatibility and enhanced push notification features.

android/app/src/main/AndroidManifest.xml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
2424
<!-- Required for scheduling local notifications -->
2525
<uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM"/>
26-
<uses-permission android:name="android.permission.USE_EXACT_ALARM" />
2726
<!-- Ignore deprecation: We still need this for the RN I think -->
2827
<uses-permission android:name="android.permission.USE_FINGERPRINT"/>
2928
<!-- Ignore deprecation -->
@@ -98,6 +97,18 @@
9897
</intent-filter>
9998
</activity>
10099

100+
<receiver android:name="com.dieam.reactnativepushnotification.modules.RNPushNotificationActions"/>
101+
<receiver android:name="com.dieam.reactnativepushnotification.modules.RNPushNotificationPublisher"/>
102+
<receiver
103+
android:name="com.dieam.reactnativepushnotification.modules.RNPushNotificationBootEventReceiver"
104+
android:exported="true">
105+
<intent-filter>
106+
<action android:name="android.intent.action.BOOT_COMPLETED"/>
107+
<action android:name="android.intent.action.QUICKBOOT_POWERON"/>
108+
<action android:name="com.htc.intent.action.QUICKBOOT_POWERON"/>
109+
</intent-filter>
110+
</receiver>
111+
101112
<service
102113
android:name=".firebase.FirebaseMessagingService"
103114
android:exported="false">

android/app/src/main/java/com/mendix/developerapp/firebase/FirebaseMessagingService.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import android.net.Uri
99
import android.os.Build
1010
import android.util.Log
1111
import androidx.core.app.NotificationCompat
12+
import com.dieam.reactnativepushnotification.modules.RNPushNotificationListenerService
1213
import com.google.firebase.messaging.RemoteMessage
1314
import com.mendix.developerapp.R
1415

@@ -38,7 +39,7 @@ class FirebaseMessagingService: com.google.firebase.messaging.FirebaseMessagingS
3839
}
3940

4041

41-
val notificationManager = context.getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
42+
val notificationManager = context.getSystemService(RNPushNotificationListenerService.NOTIFICATION_SERVICE) as NotificationManager
4243
// Since android Oreo notification channel is needed.
4344
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
4445
val channel = NotificationChannel(MENDIX_AD_CAMPAIGN_CHANNEL,

android/build.gradle

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,6 @@ allprojects {
6666
}
6767
google()
6868
maven { url 'https://jitpack.io' }
69-
maven {
70-
url "$rootDir/../node_modules/@notifee/react-native/android/libs"
71-
}
7269
}
7370

7471
// Build all modules with Android 16KB pages enabled

ios/DeveloperApp/AppDelegate.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,9 @@ class AppDelegate: UIResponder, UIApplicationDelegate, UNUserNotificationCenterD
123123
didReceive response: UNNotificationResponse,
124124
withCompletionHandler completionHandler: @escaping () -> Void
125125
) {
126+
if (!handleMendixNotification(response: response)) {
127+
RNCPushNotificationIOS.didReceive(response)
128+
}
126129
completionHandler()
127130
}
128131

ios/DeveloperApp/DeveloperApp-Bridging-Header.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@
33
#import "MendixNative.h"
44
#import "IQKeyboardManager/IQKeyboardManager.h"
55
#import "RNSplashScreen.h"
6+
#import "RNCPushNotificationIOS.h"

ios/DeveloperApp/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
<key>NSPhotoLibraryUsageDescription</key>
8787
<string>To use that feature the app needs access to your photo library.</string>
8888
<key>Native Binary Version</key>
89-
<integer>15</integer>
89+
<integer>14</integer>
9090
<key>NativeOTAEnabled</key>
9191
<true/>
9292
<key>ReferenceGuideUrl</key>

ios/Podfile.lock

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1892,6 +1892,8 @@ PODS:
18921892
- React-Core
18931893
- RNCPicker (2.11.0):
18941894
- React-Core
1895+
- RNCPushNotificationIOS (1.10.1):
1896+
- React-Core
18951897
- RNDateTimePicker (8.2.0):
18961898
- React-Core
18971899
- RNDeviceInfo (13.0.0):
@@ -1947,11 +1949,6 @@ PODS:
19471949
- React-Core
19481950
- RNLocalize (3.2.1):
19491951
- React-Core
1950-
- RNNotifee (9.1.8):
1951-
- React-Core
1952-
- RNNotifee/NotifeeCore (= 9.1.8)
1953-
- RNNotifee/NotifeeCore (9.1.8):
1954-
- React-Core
19551952
- RNPermissions (4.1.5):
19561953
- React-Core
19571954
- RNReanimated (3.16.1):
@@ -2211,6 +2208,7 @@ DEPENDENCIES:
22112208
- "RNCAsyncStorage (from `../node_modules/@react-native-async-storage/async-storage`)"
22122209
- "RNCMaskedView (from `../node_modules/@react-native-masked-view/masked-view`)"
22132210
- "RNCPicker (from `../node_modules/@react-native-picker/picker`)"
2211+
- "RNCPushNotificationIOS (from `../node_modules/@react-native-community/push-notification-ios`)"
22142212
- "RNDateTimePicker (from `../node_modules/@react-native-community/datetimepicker`)"
22152213
- RNDeviceInfo (from `../node_modules/react-native-device-info`)
22162214
- RNFastImage (from `../node_modules/react-native-fast-image`)
@@ -2223,7 +2221,6 @@ DEPENDENCIES:
22232221
- RNGestureHandler (from `../node_modules/react-native-gesture-handler`)
22242222
- RNInAppBrowser (from `../node_modules/react-native-inappbrowser-reborn`)
22252223
- RNLocalize (from `../node_modules/react-native-localize`)
2226-
- "RNNotifee (from `../node_modules/@notifee/react-native`)"
22272224
- RNPermissions (from `../node_modules/react-native-permissions`)
22282225
- RNReanimated (from `../node_modules/react-native-reanimated`)
22292226
- RNScreens (from `../node_modules/react-native-screens`)
@@ -2440,6 +2437,8 @@ EXTERNAL SOURCES:
24402437
:path: "../node_modules/@react-native-masked-view/masked-view"
24412438
RNCPicker:
24422439
:path: "../node_modules/@react-native-picker/picker"
2440+
RNCPushNotificationIOS:
2441+
:path: "../node_modules/@react-native-community/push-notification-ios"
24432442
RNDateTimePicker:
24442443
:path: "../node_modules/@react-native-community/datetimepicker"
24452444
RNDeviceInfo:
@@ -2464,8 +2463,6 @@ EXTERNAL SOURCES:
24642463
:path: "../node_modules/react-native-inappbrowser-reborn"
24652464
RNLocalize:
24662465
:path: "../node_modules/react-native-localize"
2467-
RNNotifee:
2468-
:path: "../node_modules/@notifee/react-native"
24692466
RNPermissions:
24702467
:path: "../node_modules/react-native-permissions"
24712468
RNReanimated:
@@ -2597,6 +2594,7 @@ SPEC CHECKSUMS:
25972594
RNCAsyncStorage: 40367e8d25522dca9c3513c7b9815a184669bd97
25982595
RNCMaskedView: de80352547bd4f0d607bf6bab363d826822bd126
25992596
RNCPicker: 124b4fb5859ba1a3fd53a91e16d1e7a0fc016e59
2597+
RNCPushNotificationIOS: 778dc253960de7b6544abe6cee86fea1e2c590ab
26002598
RNDateTimePicker: 818460dc31b0dc5ec58289003e27dd8d022fb79c
26012599
RNDeviceInfo: ae4e1a9b955b2a65314588cc7251795631925668
26022600
RNFastImage: 462a183c4b0b6b26fdfd639e1ed6ba37536c3b87
@@ -2609,7 +2607,6 @@ SPEC CHECKSUMS:
26092607
RNGestureHandler: 9bf6e8f72d2e72c8f7eb45986fe71a5005fb072d
26102608
RNInAppBrowser: 031138591f9cbf57e987d0fe97f4e73d5fc7524b
26112609
RNLocalize: e7378161f0b6a6365407eb2377aab46cc38047d8
2612-
RNNotifee: 5e3b271e8ea7456a36eec994085543c9adca9168
26132610
RNPermissions: e1ce3272c349e0e06c38d540353967737428336b
26142611
RNReanimated: 20f0d150af988258289b2d6cda655bd14945a769
26152612
RNScreens: 86e5c168cdd055a8feead28eb756ca7103918b6a

package-lock.json

Lines changed: 43 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)