Merge pull request #890 from mendix/moo/MOO-1671-make-hermes-only-option

Enable Hermes by default

Author: furkanarabaci

android/app/build.gradle

@@ -55,19 +55,6 @@ apply plugin: "com.facebook.react"
  */
 def enableProguardInReleaseBuilds = false
 
-/**
- * The preferred build flavor of JavaScriptCore (JSC).
- *
- * For example, to use the international variant, you can use:
- * `def jscFlavor = 'org.webkit:android-jsc-intl:+'`
- *
- * The international variant includes ICU i18n library and necessary data
- * allowing to use e.g. `Date.toLocaleString` and `String.localeCompare` that
- * give correct results when using with locales other than en-US. Note that
- * this variant is about 6MiB larger per architecture than default.
- */
-def jscFlavor = "org.webkit:android-jsc:+"
-
 android {
     ndkVersion rootProject.ndkVersion
     buildToolsVersion rootProject.ext.buildToolsVersion
@@ -114,7 +101,6 @@ android {
         buildConfig true
     }
     packagingOptions {
-        pickFirst "**/libjsc.so"
         pickFirst "**/libc++_shared.so"
     }
 }
@@ -128,13 +114,8 @@ dependencies {
     implementation "com.facebook.react:react-native:+"  // From node_modules
 
     // Javascript engine
-    if (hermesEnabled.toBoolean()) {
-        implementation("com.facebook.react:hermes-android")
-    } else {
-        implementation jscFlavor
-        implementation "org.webkit:android-jsc:r174650"
-    }
-    
+    implementation("com.facebook.react:hermes-android")
+
     implementation project(':react-native-localize')
     implementation project(":react-native-splash-screen")
     implementation project(":mendixnative-release")

android/gradle.properties

@@ -21,8 +21,4 @@ android.enableJetifier=true
 org.gradle.configureondemand=true
 android.disableResourceValidation=true
 android.nonTransitiveRClass=true
-android.suppressUnsupportedCompileSdk=33
-
-# Use this property to enable or disable the Hermes JS engine.
-# If set to false, you will be using JSC instead.
-hermesEnabled=false
+android.suppressUnsupportedCompileSdk=33

ios/Podfile

@@ -42,13 +42,8 @@ def common_pods
   xcconfig_file = "./Config/config.xcconfig"
   xcconfig = Xcodeproj::Config.new(xcconfig_file)
 
-  hermes_enabled = xcconfig.attributes['HERMES_ENABLED'] || 'false'
-
   use_react_native!(
     :path => config[:reactNativePath],
-    # Hermes is configurable in Studio Pro via Navigation Profile
-    :hermes_enabled => (hermes_enabled == 'YES'),
-    :fabric_enabled => false,
     # An absolute path to your application root.
     :app_path => "#{Pod::Config.instance.installation_root}/.."
   )