Skip to content

Commit 640d2ba

Browse files
[WC-2752]: fix DG2 refresh in client issue (#1369)
2 parents 0d566fe + 29b6c1b commit 640d2ba

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

packages/pluggableWidgets/datagrid-web/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Fixed
10+
11+
- We've stopped showing the loading indicator when all data were already loaded. The loading indicator was incorrectly displayed during client refresh operations involving a microflow.
12+
913
## [2.28.1] - 2024-11-21
1014

1115
### Fixed

packages/pluggableWidgets/datagrid-web/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@mendix/datagrid-web",
33
"widgetName": "Datagrid",
4-
"version": "2.28.1",
4+
"version": "2.28.2",
55
"description": "",
66
"copyright": "© Mendix Technology BV 2023. All rights reserved.",
77
"private": true,

packages/pluggableWidgets/datagrid-web/src/Datagrid.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,12 @@ const Container = observer((props: Props): ReactElement => {
8686
return false;
8787
}
8888

89+
if (!props.datasource.hasMoreItems) {
90+
return false;
91+
}
92+
8993
return props.datasource.status === ValueStatus.Loading;
90-
}, [exportProgress, isRefreshing, props.datasource.status]);
94+
}, [exportProgress, isRefreshing, props.datasource.status, props.datasource.hasMoreItems]);
9195

9296
return (
9397
<Widget

packages/pluggableWidgets/datagrid-web/src/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="Datagrid" version="2.28.1" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="Datagrid" version="2.28.2" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="Datagrid.xml" />
66
</widgetFiles>

0 commit comments

Comments
 (0)