Skip to content

Commit eeac2f2

Browse files
authored
update STEP 10 documentation (#346)
## What <!--- Write the change being made with this pull request ---> update docker image name (remove 2024 from name, align with STEP 7) ## CHECKS ⚠️ Please make sure you are aware of the following. - [ ] **The changes in this PR doesn't have private information
2 parents 306f365 + e497339 commit eeac2f2

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

document/10-docker-compose.en.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ In this step, we will learn how to use docker-compose.
1515

1616
You have a sample `Dockerfile` In `typescript/simple-mercari-web`. Modify this file to run frontend on Docker.
1717

18-
* Set the name of the repository as `build2024/web` and tag as `latest`.
18+
* Set the name of the repository as `mercari-build-training/web` and tag as `latest`.
1919

2020
Run the following and check if you can successfully open [http://localhost:3000/](http://localhost:3000/) on your browser.
2121

22-
`$ docker run -d -p 3000:3000 build2024/web:latest`
22+
`$ docker run -d -p 3000:3000 mercari-build-training/web:latest`
2323

2424

2525
## 2. Installing Docker Compose
@@ -51,7 +51,7 @@ Set up `docker-compose.yml` under `mercari-build-training/`
5151
Make a new file `docker-compose.yml` considering the following points.
5252

5353
* Docker image to use
54-
* (Option 1: Difficulty ☆) Use `build2024/app:latest` and `build2024/web:latest` made in STEP7 and STEP10-1
54+
* (Option 1: Difficulty ☆) Use `mercari-build-training/app:latest` and `mercari-build-training/web:latest` made in STEP7 and STEP10-1
5555
* (Option 2: Difficulty ☆☆☆) Build from `{go|python}/Dockerfile` and `typescript/simple-mercari-web/Dockerfile`
5656
* Port numbers
5757
* API : 9000

document/10-docker-compose.ja.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515

1616
`typescript/simple-mercari-web`以下にフロントエンド用の `Dockerfile` がすでに用意されています。これを変更しフロントエンドが docker 上で立ち上がるようにしましょう。
1717

18-
* 名前(リポジトリ名)は `build2024/web`, タグは`latest` とします。
18+
* 名前(リポジトリ名)は `mercari-build-training/web`, タグは`latest` とします。
1919

20-
`$ docker run -d -p 3000:3000 build2024/web:latest`
20+
`$ docker run -d -p 3000:3000 mercari-build-training/web:latest`
2121

2222
を実行し、ブラウザから[http://localhost:3000/](http://localhost:3000/)が正しく開ければ成功です。
2323

@@ -49,7 +49,7 @@
4949
以下の点を参考にしながら `docker-compose.yml` を作成しましょう。
5050

5151
* 使用する docker image
52-
* (Option 1: 難易度 ☆) STEP7 と STEP10-1 でそれぞれ build した `build2024/app:latest``build2024/web:latest` を使う
52+
* (Option 1: 難易度 ☆) STEP7 と STEP10-1 でそれぞれ build した `mercari-build-training/app:latest``mercari-build-training/web:latest` を使う
5353
* (Option 2: 難易度 ☆☆☆) `{go|python}/Dockerfile``typescript/simple-mercari-web/Dockerfile` から build するようにする
5454
* 使用する port
5555
* API : 9000

0 commit comments

Comments
 (0)