Access document instance in onResolution hook

[salmanm]

In preExecution hook, we get schema, document and context params. But in onResolution, we don't get document.

It makes sense in preExecution, coz it allows to modify it, but it would be helpful to get access to it in the onResolution too. It should be useful to perform some actions based on it. For example, I'm writing audit logs based on query name.

Thoughts?

[mcollina]

Seems like a good feature to add.

[salmanm]

If we look at the function signature, document should be before context in onResolution. But then that would be a breaking change!

preExecution

fastify.graphql.addHook('preExecution', async (schema, document, context) => {

onResolution

fastify.graphql.addHook('onResolution', async (execution, context) => {

For now, I'll just use this feature. Didn't know it exists. 😄

[mcollina]

Feel free to send the PR, I would land it when we bump the major.

[dillonius01]

Hi @mcollina , are you still open to a breaking change here for adding document to the onResolution handler? I would be happy to work on a PR but wanted to check with you first. We're currently hacking a workaround where we leverage a preExecution hook to append metadata from document onto context (use case is to drive some metrics reporting). Please let me know, and thanks!