From 1aff78ffe7069228a9249d98a2069e24213c5064 Mon Sep 17 00:00:00 2001
From: sylwia-werner <werner.sylwia38@gmail.com>
Date: Wed, 12 Nov 2025 17:23:38 +0100
Subject: [PATCH 1/2] fix: error on commision line details

---
 .../components/commission-detail.tsx             | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/routes/commission-lines/components/commission-detail.tsx b/src/routes/commission-lines/components/commission-detail.tsx
index 22f2750..07d99ab 100644
--- a/src/routes/commission-lines/components/commission-detail.tsx
+++ b/src/routes/commission-lines/components/commission-detail.tsx
@@ -68,20 +68,20 @@ export function CommissionLineDetail({ line, open, close }: Props) {
             <legend className="mt-4">Rate details</legend>
             <Container>
               <div className="flex flex-col gap-2">
-                <Text>{`Rule name: ${line.rule.name}`}</Text>
-                <Text>{`Reference: ${line.rule.reference}`}</Text>
-                <Text>{`Type: ${line.rule.rate.type}`}</Text>
-                {line.rule.rate.type === "percentage" && (
+                <Text>{`Rule name: ${line.rule?.name}`}</Text>
+                <Text>{`Reference: ${line.rule?.reference}`}</Text>
+                <Text>{`Type: ${line.rule?.rate?.type}`}</Text>
+                {line.rule?.rate.type === "percentage" && (
                   <>
-                    <Text>{`Rate value: ${line.rule.rate.percentage_rate}%`}</Text>
-                    <Text>{`Include tax: ${line.rule.rate.include_tax ? "Yes" : "No"}`}</Text>
+                    <Text>{`Rate value: ${line.rule?.rate?.percentage_rate}%`}</Text>
+                    <Text>{`Include tax: ${line.rule?.rate?.include_tax ? "Yes" : "No"}`}</Text>
                   </>
                 )}
-                {line.rule.deleted_at !== null && (
+                {line.rule?.deleted_at !== null && (
                   <Text
                     size="large"
                     weight="plus"
-                  >{`Rule was deleted at ${formatDate(line.rule.deleted_at)}!`}</Text>
+                  >{`Rule was deleted at ${formatDate(line.rule?.deleted_at)}!`}</Text>
                 )}
               </div>
             </Container>

From 611e4b0974665db50f253c3b8b2a9c517786f1f2 Mon Sep 17 00:00:00 2001
From: sylwia-werner <werner.sylwia38@gmail.com>
Date: Thu, 13 Nov 2025 10:53:07 +0100
Subject: [PATCH 2/2] fix: correct display of data in commision detail modal

---
 .../components/commission-detail.tsx                 | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/routes/commission-lines/components/commission-detail.tsx b/src/routes/commission-lines/components/commission-detail.tsx
index 07d99ab..89e9957 100644
--- a/src/routes/commission-lines/components/commission-detail.tsx
+++ b/src/routes/commission-lines/components/commission-detail.tsx
@@ -60,7 +60,7 @@ export function CommissionLineDetail({ line, open, close }: Props) {
             <legend className="mt-4">Calculated commission value</legend>
             <Container>
               <div className="flex items-center justify-between">
-                <Text>{`${line.value} ${line.currency_code.toUpperCase()}`}</Text>
+                <Text>{`${line.value === null ? '-' : line.value} ${line.currency_code.toUpperCase()}`}</Text>
               </div>
             </Container>
           </fieldset>
@@ -68,20 +68,20 @@ export function CommissionLineDetail({ line, open, close }: Props) {
             <legend className="mt-4">Rate details</legend>
             <Container>
               <div className="flex flex-col gap-2">
-                <Text>{`Rule name: ${line.rule?.name}`}</Text>
-                <Text>{`Reference: ${line.rule?.reference}`}</Text>
-                <Text>{`Type: ${line.rule?.rate?.type}`}</Text>
+                <Text>{`Rule name: ${line.rule?.name ?? '-'}`}</Text>
+                <Text>{`Reference: ${line.rule?.reference ?? '-'}`}</Text>
+                <Text>{`Type: ${line.rule?.rate?.type ?? '-'}`}</Text>
                 {line.rule?.rate.type === "percentage" && (
                   <>
                     <Text>{`Rate value: ${line.rule?.rate?.percentage_rate}%`}</Text>
                     <Text>{`Include tax: ${line.rule?.rate?.include_tax ? "Yes" : "No"}`}</Text>
                   </>
                 )}
-                {line.rule?.deleted_at !== null && (
+                {line.rule?.deleted_at && (
                   <Text
                     size="large"
                     weight="plus"
-                  >{`Rule was deleted at ${formatDate(line.rule?.deleted_at)}!`}</Text>
+                  >{`Rule was deleted at ${formatDate(line.rule?.deleted_at)}`}</Text>
                 )}
               </div>
             </Container>