MM2-1535 Fix login validation UI #227
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kacpergumieniuk
left a comment
kacpergumieniuk
left a comment
There was a problem hiding this comment.
We can adjust case (change the copy to one from Figma), when email is not valid (frontend validation)
Invalid email -> Please enter a valid email
kacpergumieniuk
left a comment
kacpergumieniuk
left a comment
There was a problem hiding this comment.
I guess there is no backend logic to check if requested password change account exist to cover this case from figma ? Maybe Backend task should be created?
| import { zodResolver } from "@hookform/resolvers/zod" | ||
| import { LabeledInput } from "@/components/cells" | ||
| import { forgotPasswordSchema, ForgotPasswordFormData } from "./schema" | ||
| import { useState } from "react" |
There was a problem hiding this comment.
We can remove unused imports in this file
|
|
||
| return ( | ||
| <div className="max-w-xl w-full mx-auto mt-6 space-y-4 rounded-sm border p-4"> | ||
| <h1 className="heading-md uppercase my-0 mb-2">Forgot your password?</h1> |
There was a problem hiding this comment.
This heading is black in figma instead of greyish.
There was a problem hiding this comment.
Right, changed
kacpergumieniuk
left a comment
kacpergumieniuk
left a comment
There was a problem hiding this comment.
Requested some changes
|
can't reply directly for
yes, there is no validation if an account actually exists - but should we check it? it would allow account enumeration Update -> Discussed it with QA, account validation can be implemented 
|
Note: to merge after #222 is merged