fix: introduce Index Module to allow filtering and sorting by linked modules properties (seller - customer group) #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iltering on linked enities fields
…03-b-2-c-vendor-panel-sorting-and-searching-throw-a-view-with-error-message-on-campaigns-view
…-a-view-with-error-message-on-campaigns-view' of github.com:mercurjs/mercur into MM2-1403-b-2-c-vendor-panel-sorting-and-searching-throw-a-view-with-error-message-on-campaigns-view
…modules properties (seller - customer group)
|
🚅 Deployed to the mercur-pr-495 environment in [DEV & QA] mercur-internal
|
railway-app
bot
temporarily deployed
to
mercur ([DEV & QA] mercur-internal / mercur-pr-495)
…03-b-2-c-vendor-panel-sorting-and-searching-throw-a-view-with-error-message-on-campaigns-view
…ting-and-searching-throw-a-view-with-error-message-on-campaigns-view Bugfix: Sorting and searching throw a view with error message on Campaigns view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only downside of using Index Module that I can see right now is that it does not supprt partial search with q param. Due to that I've extended validator for name field to accept also objects. Thanks to that FE can use
name[$ilike]=examplein query params to search for partial matches. This is not the perfect solution as we have 2 ways for searching which can lead to potentail issues. This topic should be discussed with whole team.