HG Core: prevent hg_core_init() segv on version check error#845
Merged
soumagne merged 1 commit intomercury-hpc:masterfrom Nov 25, 2025
Merged
HG Core: prevent hg_core_init() segv on version check error#845soumagne merged 1 commit intomercury-hpc:masterfrom
soumagne merged 1 commit intomercury-hpc:masterfrom
Conversation
Go to "error_free" instead of "error" in the HG_CHECK_SUBSYS_ERROR() check for newer versions to avoid a core dump. hg_core_class is NULL (have not called calloc yet) and "error" assumes it is not. Issue found by Sheng Jiang.
soumagne
approved these changes
Nov 25, 2025
Member
|
Thanks for the fix @chuckcranor ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go to "error_free" instead of "error" in the HG_CHECK_SUBSYS_ERROR() check for newer versions to avoid a core dump. hg_core_class is NULL (have not called calloc yet) and "error" assumes it is not. Issue found by Sheng Jiang.