Merge pull request #1238 from merico-dev/1237-wrong-encoding-in-csv-files-from-download-data

1237 wrong encoding in csv files from download data

Author: GerilLeto

api/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devtable/api",
-  "version": "10.45.1",
+  "version": "10.45.2",
   "description": "",
   "main": "index.js",
   "scripts": {

dashboard/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devtable/dashboard",
-  "version": "10.45.1",
+  "version": "10.45.2",
   "license": "Apache-2.0",
   "publishConfig": {
     "access": "public",

dashboard/src/utils/download.ts

@@ -1,4 +1,5 @@
 import { AsyncParser } from '@json2csv/whatwg';
+import { notifications } from '@mantine/notifications';
 import { saveAs } from 'file-saver';
 import JSZip from 'jszip';
 
@@ -23,12 +24,24 @@ export async function downloadDataAsCSV(id: string, data: TQueryData) {
 
 export function downloadDataListAsZip(idDataList: Array<{ id: string; data: TQueryData }>) {
   const zip = new JSZip();
-  idDataList.forEach(({ id, data }) => {
-    zip.file(`${id}.csv`, makeCSV(data));
-  });
-  zip.generateAsync({ type: 'blob' }).then((content) => {
-    saveAs(content, 'dashboard_data.zip');
+  const promises = idDataList.map(async ({ id, data }) => {
+    const csv = await makeCSV(data);
+    zip.file(`${id}.csv`, csv);
   });
+  Promise.all(promises)
+    .then(() => {
+      zip.generateAsync({ type: 'blob' }).then((content) => {
+        saveAs(content, 'dashboard_data.zip');
+      });
+    })
+    .catch((err) => {
+      console.error(err);
+      notifications.show({
+        color: 'red',
+        title: 'Failed to download data',
+        message: err.message,
+      });
+    });
 }
 
 export function downloadJSON(name: string, json: string) {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devtable/root",
-  "version": "10.45.1",
+  "version": "10.45.2",
   "private": true,
   "workspaces": [
     "api",

settings-form/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devtable/settings-form",
-  "version": "10.45.1",
+  "version": "10.45.2",
   "license": "Apache-2.0",
   "publishConfig": {
     "access": "public",

website/package.json

@@ -2,7 +2,7 @@
   "name": "@devtable/website",
   "private": true,
   "license": "Apache-2.0",
-  "version": "10.45.1",
+  "version": "10.45.2",
   "scripts": {
     "dev": "vite",
     "preview": "vite preview"