@agoetz I took a stab at this in #328. However, going from the legacy MPI Fortran include directives to using the mpi_f08 module is more involved (see the details in the next paragraph). As a first attempt, the mentioned PR instead changes to the mpi module.

As to converting to mpi_f08 usage, the following issues came up:

Some MPI datatypes have changed in the mpi_f08 module. For example, MPI_Status changed from a basic integer datatype to type(MPI_Status).
Some variables in QUICK have naming comflicts with variables in the mpi_f08 module. For example, MPI_STATUS in src/modules/quick_mpi_module.F90.
It appears that the CMake build system is currently compiling QUICK MPI-specific sources for non-MPI targets. I noticed this when I refactored code to address the above two points. After doing so, I run into build errors with the new QUICK_MPI_STATUS variable in src/modules/quick_mpi_module.F90 is defined as type(MPI_Status). Surrounding with the conditional preprocessor directive MPIV can work around these errors for at least this source file (and maybe other source files using QUICK_MPI_STATUS), but this raises the larger question of why MPIV is needed as a hack to work around build system issues.
There may be more issues lurking in MPI routine calls. The current changes in MPI Fortran modernization #328 already caught one issue (in src/modules/quick_method_module.f90 -- see src/modules/quick_method_module.f90).

Update Fortran MPI support #316

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions