chore: add a random suffix to gh repos created via aks starterkit

also includes making archive_on_destroy configurable in GH repo building block

Author: malhussan

modules/aks/starterkit/buildingblock/README.md

@@ -34,11 +34,13 @@ No modules.
 | [meshstack_project_user_binding.creator_prod_admin](https://registry.terraform.io/providers/meshcloud/meshstack/0.15.0/docs/resources/project_user_binding) | resource |
 | [meshstack_tenant_v4.dev](https://registry.terraform.io/providers/meshcloud/meshstack/0.15.0/docs/resources/tenant_v4) | resource |
 | [meshstack_tenant_v4.prod](https://registry.terraform.io/providers/meshcloud/meshstack/0.15.0/docs/resources/tenant_v4) | resource |
+| [random_id.repo_suffix](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/id) | resource |
 
 ## Inputs
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
+| <a name="input_archive_repo_on_destroy"></a> [archive\_repo\_on\_destroy](#input\_archive\_repo\_on\_destroy) | Whether to archive github repository when destroying the terraform resource, or delete it. Defaults to true (archive). | `bool` | `true` | no |
 | <a name="input_creator"></a> [creator](#input\_creator) | Information about the creator of the resources who will be assigned Project Admin role | <pre>object({<br>    type        = string<br>    identifier  = string<br>    displayName = string<br>    username    = optional(string)<br>    email       = optional(string)<br>    euid        = optional(string)<br>  })</pre> | n/a | yes |
 | <a name="input_full_platform_identifier"></a> [full\_platform\_identifier](#input\_full\_platform\_identifier) | Full platform identifier of the AKS Namespace platform. | `string` | n/a | yes |
 | <a name="input_github_actions_connector_definition_version_uuid"></a> [github\_actions\_connector\_definition\_version\_uuid](#input\_github\_actions\_connector\_definition\_version\_uuid) | UUID of the GitHub Actions connector building block definition version. | `string` | n/a | yes |

modules/aks/starterkit/buildingblock/main.tf

@@ -5,6 +5,13 @@ locals {
 
   # Decode project tags YAML configuration
   project_tags_config = yamldecode(var.project_tags_yaml)
+
+  repo_name = "${local.identifier}-${random_id.repo_suffix.hex}"
+}
+
+# Generate a random suffix for the repository name to ensure uniqueness
+resource "random_id" "repo_suffix" {
+  byte_length = 4 // 8 hex characters
 }
 
 resource "meshstack_project" "dev" {
@@ -109,7 +116,10 @@ resource "meshstack_building_block_v2" "repo" {
 
     inputs = {
       repo_name = {
-        value_string = local.identifier
+        value_string = local.repo_name
+      }
+      archive_repo_on_destroy = {
+        value_bool = var.archive_repo_on_destroy
       }
       repo_owner = {
         value_string = var.repo_admin != null ? var.repo_admin : "null"

modules/aks/starterkit/buildingblock/variables.tf

@@ -43,6 +43,12 @@ variable "github_repo_input_repo_visibility" {
   default     = "private"
 }
 
+variable "archive_repo_on_destroy" {
+  type        = bool
+  description = "Whether to archive github repository when destroying the terraform resource, or delete it. Defaults to true (archive)."
+  default     = true
+}
+
 variable "github_org" {
   type        = string
   description = "GitHub organization name. Used only for display purposes."

modules/github/repository/buildingblock/README.md

@@ -32,6 +32,7 @@ No modules.
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
+| <a name="input_archive_repo_on_destroy"></a> [archive\_repo\_on\_destroy](#input\_archive\_repo\_on\_destroy) | Whether to archive github repository when destroying the terraform resource, or delete it. Defaults to true (archive). | `bool` | `true` | no |
 | <a name="input_repo_description"></a> [repo\_description](#input\_repo\_description) | Description of the GitHub repository | `string` | `"created by github-repo-building-block"` | no |
 | <a name="input_repo_name"></a> [repo\_name](#input\_repo\_name) | Name of the GitHub repository | `string` | `"github-repo"` | no |
 | <a name="input_repo_owner"></a> [repo\_owner](#input\_repo\_owner) | Username of the GitHub user who will be set as the owner/admin of the repository. If not set, no collaborator will be added. | `string` | `null` | no |

modules/github/repository/buildingblock/main.tf

@@ -4,7 +4,7 @@ resource "github_repository" "repository" {
   visibility           = var.repo_visibility
   auto_init            = false
   vulnerability_alerts = true
-  archive_on_destroy   = true
+  archive_on_destroy   = var.archive_repo_on_destroy
 
   dynamic "template" {
     for_each = var.use_template ? [1] : []

modules/github/repository/buildingblock/variables.tf

@@ -1,3 +1,9 @@
+variable "archive_repo_on_destroy" {
+  type        = bool
+  default     = true
+  description = "Whether to archive github repository when destroying the terraform resource, or delete it. Defaults to true (archive)."
+}
+
 variable "repo_description" {
   type        = string
   default     = "created by github-repo-building-block"