fix: fixing tests

Author: florianow

README.md

@@ -169,6 +169,7 @@ aws s3 ls --endpoint-url https://your-domain.region.azurecontainer.io:8443 --no-
 | Name | Version |
 |------|---------|
 | <a name="requirement_azurerm"></a> [azurerm](#requirement\_azurerm) | 4.36.0 |
+| <a name="requirement_random"></a> [random](#requirement\_random) | ~> 3.1 |
 
 ## Modules
 
@@ -183,24 +184,25 @@ No modules.
 | [azurerm_resource_group.minio_aci_rg](https://registry.terraform.io/providers/hashicorp/azurerm/4.36.0/docs/resources/resource_group) | resource |
 | [azurerm_storage_account.minio_storage_account](https://registry.terraform.io/providers/hashicorp/azurerm/4.36.0/docs/resources/storage_account) | resource |
 | [azurerm_storage_share.minio_storage_share](https://registry.terraform.io/providers/hashicorp/azurerm/4.36.0/docs/resources/storage_share) | resource |
+| [random_string.storage_suffix](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/string) | resource |
 
 ## Inputs
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | <a name="input_cert_password"></a> [cert\_password](#input\_cert\_password) | Password for the SSL certificate | `string` | n/a | yes |
 | <a name="input_coraza_waf_image"></a> [coraza\_waf\_image](#input\_coraza\_waf\_image) | Coraza WAF container image | `string` | `"ghcr.io/meshcloud/minio_azure_container_app/coraza-caddy:caddy-2.8-coraza-v2.0.0"` | no |
-| <a name="input_location"></a> [location](#input\_location) | Azure region for deployment | `string` | n/a | yes |
+| <a name="input_location"></a> [location](#input\_location) | Azure region for deployment | `string` | `"West Europe"` | no |
 | <a name="input_minio_image"></a> [minio\_image](#input\_minio\_image) | MinIO container image | `string` | `"quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z"` | no |
 | <a name="input_minio_root_password"></a> [minio\_root\_password](#input\_minio\_root\_password) | MinIO root password for admin access | `string` | n/a | yes |
-| <a name="input_minio_root_user"></a> [minio\_root\_user](#input\_minio\_root\_user) | MinIO root username for admin access | `string` | n/a | yes |
+| <a name="input_minio_root_user"></a> [minio\_root\_user](#input\_minio\_root\_user) | MinIO root username for admin access | `string` | `"minioadmin"` | no |
 | <a name="input_nginx_image"></a> [nginx\_image](#input\_nginx\_image) | Nginx container image | `string` | `"mcr.microsoft.com/azurelinux/base/nginx:1.25"` | no |
 | <a name="input_public_url_domain_name"></a> [public\_url\_domain\_name](#input\_public\_url\_domain\_name) | Domain name for the public URL (e.g., 'miniotest' creates 'miniotest.westeurope.azurecontainer.io') | `string` | n/a | yes |
 | <a name="input_resource_group_name"></a> [resource\_group\_name](#input\_resource\_group\_name) | Name of the Resource Group where you want to deploy MinIO | `string` | n/a | yes |
 | <a name="input_ssl_cert_file"></a> [ssl\_cert\_file](#input\_ssl\_cert\_file) | Name of the SSL certificate file | `string` | `"server.crt"` | no |
 | <a name="input_ssl_key_file"></a> [ssl\_key\_file](#input\_ssl\_key\_file) | Name of the SSL private key file | `string` | `"server.key"` | no |
-| <a name="input_storage_account_name"></a> [storage\_account\_name](#input\_storage\_account\_name) | Storage Account Name (must be globally unique across Azure) | `string` | n/a | yes |
-| <a name="input_storage_share_size"></a> [storage\_share\_size](#input\_storage\_share\_size) | Storage space needed in GBs (minimum 1GB, maximum 5120GB/5TB) | `number` | n/a | yes |
+| <a name="input_storage_account_name"></a> [storage\_account\_name](#input\_storage\_account\_name) | Storage Account Name prefix (random suffix will be added for global uniqueness) | `string` | `"miniostorage"` | no |
+| <a name="input_storage_share_size"></a> [storage\_share\_size](#input\_storage\_share\_size) | Storage space needed in GBs (minimum 1GB, maximum 5120GB/5TB) | `number` | `100` | no |
 
 ## Outputs
 

main.tf

@@ -1,3 +1,9 @@
+resource "random_string" "storage_suffix" {
+  length  = 4
+  special = false
+  upper   = false
+}
+
 resource "azurerm_resource_group" "minio_aci_rg" {
   name     = var.resource_group_name
   location = var.location
@@ -201,7 +207,7 @@ resource "azurerm_log_analytics_workspace" "minio_law" {
 }
 
 resource "azurerm_storage_account" "minio_storage_account" {
-  name                              = var.storage_account_name
+  name                              = "${var.storage_account_name}${random_string.storage_suffix.result}"
   resource_group_name               = azurerm_resource_group.minio_aci_rg.name
   location                          = var.location
   account_tier                      = "Standard"

terraform.tftest.hcl

@@ -10,7 +10,7 @@ run "complete_minio_deployment" {
     ssl_key_file           = "server-tftest.key"
     cert_password          = "CertPassword123!"
     storage_share_size     = 100
-    storage_account_name   = "testminiostorage001"
+    storage_account_name   = "testminio" # prefix only
     public_url_domain_name = "testminio"
   }
 
@@ -62,12 +62,7 @@ run "complete_minio_deployment" {
     error_message = "Container group should expose MinIO API port 8443"
   }
 
-  # Test storage configuration
-  assert {
-    condition     = azurerm_storage_account.minio_storage_account.name == var.storage_account_name
-    error_message = "Storage account should use the specified name"
-  }
-
+  # Test storage configuration (prefix + random suffix handled in resource)
   assert {
     condition     = azurerm_storage_share.minio_storage_share.quota == var.storage_share_size
     error_message = "Storage share should use the specified size"
@@ -111,7 +106,7 @@ run "nginx_ssl_configuration" {
     ssl_key_file           = "server-tftest.key"
     cert_password          = "CertPassword123!"
     storage_share_size     = 100
-    storage_account_name   = "testminiostorage002"
+    storage_account_name   = "testminio002"
     public_url_domain_name = "testminio"
   }
 
@@ -152,7 +147,7 @@ run "storage_size_validation" {
     ssl_key_file           = "server-tftest.key"
     cert_password          = "CertPassword123!"
     storage_share_size     = 1000
-    storage_account_name   = "testminiostorage003"
+    storage_account_name   = "testminio003"
     public_url_domain_name = "testminio"
   }
 
@@ -177,7 +172,7 @@ run "invalid_storage_size" {
     ssl_key_file           = "server-tftest.key"
     cert_password          = "CertPassword123!"
     storage_share_size     = 0
-    storage_account_name   = "testminiostorage004"
+    storage_account_name   = "testminio004"
     public_url_domain_name = "testminio"
   }
 }
@@ -197,7 +192,7 @@ run "invalid_storage_size_too_large" {
     ssl_key_file           = "server-tftest.key"
     cert_password          = "CertPassword123!"
     storage_share_size     = 6000
-    storage_account_name   = "testminiostorage005"
+    storage_account_name   = "testminio005"
     public_url_domain_name = "testminio"
   }
 }
@@ -216,7 +211,7 @@ run "empty_credentials" {
     minio_root_password    = ""
     cert_password          = "CertPassword123!"
     storage_share_size     = 100
-    storage_account_name   = "testminiostorage006"
+    storage_account_name   = "testminio006"
     public_url_domain_name = "testminio"
   }
 }
@@ -236,7 +231,7 @@ run "missing_certificate" {
     ssl_key_file           = "server-tftest.key"
     cert_password          = ""
     storage_share_size     = 100
-    storage_account_name   = "testminiostorage007"
+    storage_account_name   = "testminio007"
     public_url_domain_name = "testminio"
   }
 }

variables.tf

@@ -4,11 +4,13 @@ variable "resource_group_name" {
 }
 
 variable "location" {
+  default     = "West Europe"
   type        = string
   description = "Azure region for deployment"
 }
 
 variable "minio_root_user" {
+  default     = "minioadmin"
   type        = string
   nullable    = false
   description = "MinIO root username for admin access"
@@ -41,6 +43,7 @@ variable "cert_password" {
 }
 
 variable "storage_share_size" {
+  default     = 100
   type        = number
   description = "Storage space needed in GBs (minimum 1GB, maximum 5120GB/5TB)"
   validation {
@@ -51,9 +54,15 @@ variable "storage_share_size" {
 
 variable "storage_account_name" {
   type        = string
-  description = "Storage Account Name (must be globally unique across Azure)"
+  default     = "miniostorage"
+  description = "Storage Account Name prefix (random suffix will be added for global uniqueness)"
+  validation {
+    condition     = can(regex("^[a-z0-9]{3,24}$", var.storage_account_name))
+    error_message = "Storage account name prefix must be 3-24 characters, lowercase letters and numbers only. No special characters or uppercase letters allowed."
+  }
 }
 
+
 variable "public_url_domain_name" {
   type        = string
   description = "Domain name for the public URL (e.g., 'miniotest' creates 'miniotest.westeurope.azurecontainer.io')"

versions.tf

@@ -4,6 +4,9 @@ terraform {
       source  = "hashicorp/azurerm"
       version = "4.36.0"
     }
+    random = {
+      source  = "hashicorp/random"
+      version = "~> 3.1"
+    }
   }
 }
-