refactor: buildingblock status constants

Author: malhussan

client/buildingblock_v2.go

@@ -14,6 +14,14 @@ import (
 
 const (
 	CONTENT_TYPE_BUILDING_BLOCK_V2 = "application/vnd.meshcloud.api.meshbuildingblock.v2-preview.hal+json"
+
+	// Building Block Status Constants
+	BUILDING_BLOCK_STATUS_WAITING_FOR_DEPENDENT_INPUT = "WAITING_FOR_DEPENDENT_INPUT"
+	BUILDING_BLOCK_STATUS_WAITING_FOR_OPERATOR_INPUT  = "WAITING_FOR_OPERATOR_INPUT"
+	BUILDING_BLOCK_STATUS_PENDING                     = "PENDING"
+	BUILDING_BLOCK_STATUS_IN_PROGRESS                 = "IN_PROGRESS"
+	BUILDING_BLOCK_STATUS_SUCCEEDED                   = "SUCCEEDED"
+	BUILDING_BLOCK_STATUS_FAILED                      = "FAILED"
 )
 
 type MeshBuildingBlockV2 struct {
@@ -172,10 +180,10 @@ func (c *MeshStackProviderClient) waitForBuildingBlockV2CompletionFunc(uuid stri
 		// Check if we've reached a terminal state
 		status := current.Status.Status
 		switch status {
-		case "SUCCEEDED":
+		case BUILDING_BLOCK_STATUS_SUCCEEDED:
 			*result = current
 			return nil // Success, stop retrying
-		case "FAILED":
+		case BUILDING_BLOCK_STATUS_FAILED:
 			return retry.NonRetryableError(fmt.Errorf("building block %s reached FAILED state", uuid))
 		}
 
@@ -204,7 +212,7 @@ func (c *MeshStackProviderClient) waitForBuildingBlockV2DeletionFunc(uuid string
 		}
 
 		// If building block is in FAILED state during deletion, consider it a terminal state
-		if current.Status.Status == "FAILED" {
+		if current.Status.Status == BUILDING_BLOCK_STATUS_FAILED {
 			return retry.NonRetryableError(fmt.Errorf("building block %s reached FAILED state during deletion. For more details, check the building block run logs in meshStack", uuid))
 		}
 

internal/provider/building_block_v2_data_source.go

@@ -188,10 +188,23 @@ func (d *buildingBlockV2DataSource) Schema(ctx context.Context, req datasource.S
 				Computed:            true,
 				Attributes: map[string]schema.Attribute{
 					"status": schema.StringAttribute{
-						MarkdownDescription: "Execution status. One of `WAITING_FOR_DEPENDENT_INPUT`, `WAITING_FOR_OPERATOR_INPUT`, `PENDING`, `IN_PROGRESS`, `SUCCEEDED`, `FAILED`.",
-						Computed:            true,
+						MarkdownDescription: fmt.Sprintf("Execution status. One of `%s`, `%s`, `%s`, `%s`, `%s`, `%s`.",
+							client.BUILDING_BLOCK_STATUS_WAITING_FOR_DEPENDENT_INPUT,
+							client.BUILDING_BLOCK_STATUS_WAITING_FOR_OPERATOR_INPUT,
+							client.BUILDING_BLOCK_STATUS_PENDING,
+							client.BUILDING_BLOCK_STATUS_IN_PROGRESS,
+							client.BUILDING_BLOCK_STATUS_SUCCEEDED,
+							client.BUILDING_BLOCK_STATUS_FAILED),
+						Computed: true,
 						Validators: []validator.String{
-							stringvalidator.OneOf([]string{"WAITING_FOR_DEPENDENT_INPUT", "WAITING_FOR_OPERATOR_INPUT", "PENDING", "IN_PROGRESS", "SUCCEEDED", "FAILED"}...),
+							stringvalidator.OneOf([]string{
+								client.BUILDING_BLOCK_STATUS_WAITING_FOR_DEPENDENT_INPUT,
+								client.BUILDING_BLOCK_STATUS_WAITING_FOR_OPERATOR_INPUT,
+								client.BUILDING_BLOCK_STATUS_PENDING,
+								client.BUILDING_BLOCK_STATUS_IN_PROGRESS,
+								client.BUILDING_BLOCK_STATUS_SUCCEEDED,
+								client.BUILDING_BLOCK_STATUS_FAILED,
+							}...),
 						},
 					},
 					"force_purge": schema.BoolAttribute{

internal/provider/building_block_v2_resource.go

@@ -266,10 +266,23 @@ func (r *buildingBlockV2Resource) Schema(ctx context.Context, req resource.Schem
 				PlanModifiers:       []planmodifier.Object{objectplanmodifier.UseStateForUnknown()},
 				Attributes: map[string]schema.Attribute{
 					"status": schema.StringAttribute{
-						MarkdownDescription: "Execution status. One of `WAITING_FOR_DEPENDENT_INPUT`, `WAITING_FOR_OPERATOR_INPUT`, `PENDING`, `IN_PROGRESS`, `SUCCEEDED`, `FAILED`.",
-						Computed:            true,
+						MarkdownDescription: fmt.Sprintf("Execution status. One of `%s`, `%s`, `%s`, `%s`, `%s`, `%s`.",
+							client.BUILDING_BLOCK_STATUS_WAITING_FOR_DEPENDENT_INPUT,
+							client.BUILDING_BLOCK_STATUS_WAITING_FOR_OPERATOR_INPUT,
+							client.BUILDING_BLOCK_STATUS_PENDING,
+							client.BUILDING_BLOCK_STATUS_IN_PROGRESS,
+							client.BUILDING_BLOCK_STATUS_SUCCEEDED,
+							client.BUILDING_BLOCK_STATUS_FAILED),
+						Computed: true,
 						Validators: []validator.String{
-							stringvalidator.OneOf([]string{"WAITING_FOR_DEPENDENT_INPUT", "WAITING_FOR_OPERATOR_INPUT", "PENDING", "IN_PROGRESS", "SUCCEEDED", "FAILED"}...),
+							stringvalidator.OneOf([]string{
+								client.BUILDING_BLOCK_STATUS_WAITING_FOR_DEPENDENT_INPUT,
+								client.BUILDING_BLOCK_STATUS_WAITING_FOR_OPERATOR_INPUT,
+								client.BUILDING_BLOCK_STATUS_PENDING,
+								client.BUILDING_BLOCK_STATUS_IN_PROGRESS,
+								client.BUILDING_BLOCK_STATUS_SUCCEEDED,
+								client.BUILDING_BLOCK_STATUS_FAILED,
+							}...),
 						},
 					},
 					"force_purge": schema.BoolAttribute{
@@ -381,7 +394,7 @@ func (r *buildingBlockV2Resource) Create(ctx context.Context, req resource.Creat
 			// Always store the initial state, even if the building block was created in a failed state
 			// This allows Terraform to track the resource and handle recreates appropriately
 			resp.Diagnostics.Append(setStateFromResponseV2(&ctx, &resp.State, created)...)
-			resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("status").AtName("status"), "FAILED")...)
+			resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("status").AtName("status"), client.BUILDING_BLOCK_STATUS_FAILED)...)
 			resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("spec").AtName("inputs"), plan.Spec.Inputs)...)
 			resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("wait_for_completion"), plan.WaitForCompletion)...)