feat: add meshstack_building_block_definition, meshstack_integration resource#87
Open
feat: add meshstack_building_block_definition, meshstack_integration resource#87
Conversation
grubmeshi
force-pushed
the
cu-86c7bx3xw-bbd-resource
branch
from
c835aa1 to
7602eff
Compare
grubmeshi
changed the title
grubmeshi
force-pushed
the
cu-86c7bx3xw-bbd-resource
branch
4 times, most recently
from
46df69a to
3b6598f
Compare
grubmeshi
force-pushed
the
cu-86c7bx3xw-bbd-resource
branch
6 times, most recently
from
5aaca9b to
a98c8c9
Compare
grubmeshi
force-pushed
the
cu-86c7bx3xw-bbd-resource
branch
11 times, most recently
from
a41c92e to
ffa7040
Compare
grubmeshi
force-pushed
the
cu-86c7bx3xw-bbd-resource
branch
4 times, most recently
from
091e2e4 to
93f79d5
Compare
grubmeshi
force-pushed
the
cu-86c7bx3xw-bbd-resource
branch
3 times, most recently
from
66b0d46 to
a16aecc
Compare
…t in provider_test.go
…form, remove created_on, deleted_on
…form_type, fix missing owned_by_workspace in example
…m with generic.Set
… output, Secret support, better tests
grubmeshi
force-pushed
the
cu-86c7bx3xw-bbd-resource
branch
from
a16aecc to
2700cc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is huge, partly because it adds a ton of tests, but also the BBD resource is quite a beast.
It also introduces some more convenient Client DTO conversion to the Terraform data model using reflection.
CI tests in this PR use a mock client, but Acceptance tests
TestAcc*are also green when run against a localmeshfed-api, if that PR is in: https://github.com/meshcloud/meshfed-release/pull/9385This also provides a good basis to refactor
meshstack_platformresource concerning secrets, as the BBD and integration already show.