Merge pull request #902 from meshery/copilot/fix-golang-lint-checks

Fix golang lint failures: unchecked errors and disable ST1005 check

Author: leecalcote

.golangci.yml

@@ -1,4 +1,13 @@
 version: "2"
 
 run:
-  timeout: 5m
+  timeout: 5m
+
+linters-settings:
+  staticcheck:
+    go: "1.25"
+    checks: ["all", "-ST1005"]
+
+issues:
+  exclude:
+    - "ST1005"

generators/github/git_repo.go

@@ -41,7 +41,7 @@ func (gr GitRepo) GetContent() (models.Package, error) {
 	filePath := filepath.Join(dirPath, utils.GetRandomAlphabetsOfDigit(5))
 	fd, err := os.Create(filePath)
 	if err != nil {
-		os.RemoveAll(dirPath)
+		_ = os.RemoveAll(dirPath)
 		return nil, utils.ErrCreateFile(err, filePath)
 	}
 	br := bufio.NewWriter(fd)

models/registration/dir.go

@@ -65,7 +65,7 @@ func processDir(dirPath string, pkg *PackagingUnit, regErrStore RegistrationErro
 	var tempDirs []string
 	defer func() {
 		for _, tempDir := range tempDirs {
-			os.RemoveAll(tempDir)
+			_ = os.RemoveAll(tempDir)
 		}
 	}()
 

utils/component/generator_test.go

@@ -154,7 +154,7 @@ func TestGenerate(t *testing.T) {
 			if got.Component.Kind != tt.want.Component.Kind {
 				t.Errorf("got %v, want %v", got.Component.Kind, tt.want.Component.Kind)
 			}
-			if !(got.Component.Version == tt.want.Component.Version) {
+			if got.Component.Version != tt.want.Component.Version {
 				t.Errorf("got %v, want %v", got.Component.Version, tt.want.Component.Version)
 			}
 		})