Merge pull request #788 from abohoss/bug/abohoss/784-2

some error checks added (static checks)

Author: n2h9

converter/tests/helm_test.go

@@ -4,6 +4,7 @@ import (
 	"archive/tar"
 	"bytes"
 	"compress/gzip"
+	"fmt"
 	"io"
 	"os"
 	"strings"
@@ -139,7 +140,9 @@ func extractManifestFromChart(chartData []byte) (bool, string) {
 		}
 		if strings.HasSuffix(hdr.Name, "templates/manifest.yaml") {
 			buf := new(bytes.Buffer)
-			io.Copy(buf, tr)
+			if _, err := io.Copy(buf, tr); err != nil {
+				return false, fmt.Sprintf("failed to copy manifest content: %v", err)
+			}
 			return true, buf.String()
 		}
 	}

generators/github/url.go

@@ -3,7 +3,7 @@ package github
 import (
 	"bufio"
 	"io"
-
+	"fmt"
 	"net/url"
 	"os"
 	"path/filepath"
@@ -55,6 +55,9 @@ func (u URL) GetContent() (models.Package, error) {
 	if strings.HasSuffix(url, ".yml") || strings.HasSuffix(url, ".yaml") {
 
 		data, err := os.ReadFile(downloadfilePath)
+		if err != nil {
+			return nil, fmt.Errorf("failed to read file %s: %w", downloadfilePath, err)
+		}
 		_, err = w.Write(data)
 		if err != nil {
 			return nil, err