Skip to content

Commit b5777be

Browse files
authored
Warnings and log cleanup (#5472)
* Don't log if keyboard not found * Signed comparison issue
1 parent 5ad30a5 commit b5777be

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/gps/GPS.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ class GPS : private concurrency::OSThread
158158
uint32_t rx_gpio = 0;
159159
uint32_t tx_gpio = 0;
160160

161-
int speedSelect = 0;
162-
int probeTries = 0;
161+
uint8_t speedSelect = 0;
162+
uint8_t probeTries = 0;
163163

164164
/**
165165
* hasValidLocation - indicates that the position variables contain a complete
@@ -239,4 +239,4 @@ class GPS : private concurrency::OSThread
239239
};
240240

241241
extern GPS *gps;
242-
#endif // Exclude GPS
242+
#endif // Exclude GPS

src/input/cardKbI2cImpl.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,11 @@ void CardKbI2cImpl::init()
4949
kb_model = 0x00;
5050
}
5151
}
52-
LOG_DEBUG("Keyboard Type: 0x%02x Model: 0x%02x Address: 0x%02x", kb_info.type, kb_model, cardkb_found.address);
5352
if (cardkb_found.address == 0x00) {
5453
disable();
5554
return;
55+
} else {
56+
LOG_DEBUG("Keyboard Type: 0x%02x Model: 0x%02x Address: 0x%02x", kb_info.type, kb_model, cardkb_found.address);
5657
}
5758
}
5859
#else

0 commit comments

Comments
 (0)