Skip to content

Commit d01b51f

Browse files
brad112358fifieldt
authored andcommitted
Reassign GPS pins to match recommended optional GPS module instructions
1 parent 644b7cf commit d01b51f

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

variants/nrf52840/diy/easy-nrf52-promicro_e22/variant.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,11 @@ const uint32_t g_ADigitalPinMap[] = {
3030
// P1
3131
32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47};
3232

33+
#ifdef PIN_3V3_EN
3334
void initVariant()
3435
{
3536
// 3V3 Power Rail
3637
pinMode(PIN_3V3_EN, OUTPUT);
3738
digitalWrite(PIN_3V3_EN, HIGH);
3839
}
40+
#endif

variants/nrf52840/diy/easy-nrf52-promicro_e22/variant.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ E22/NRF52 PRO MICRO PIN ASSIGNMENT
7070
| P1.06 | SCL         |   | P0.09   | NSS         |
7171
|       |             |   |         |             |
7272
|       | Mid board   |   |         | Internal     |
73-
| P1.01 | GPS_TX     |   | 0.15     | LED         |
73+
| P1.01 | Free pin   |   | 0.15     | LED         |
7474
| P1.02 | GPS_RX     |   | 0.13     | 3V3_EN       |
75-
| P1.07 | GPS_EN     |   |         |             |
75+
| P1.07 | GPS_TX     |   |         |             |
7676
*/
7777

7878
// Number of pins defined in PinDescription array
@@ -82,7 +82,7 @@ E22/NRF52 PRO MICRO PIN ASSIGNMENT
8282
#define NUM_ANALOG_OUTPUTS (0)
8383

8484
// Pin 13 enables 3.3V periphery.
85-
#define PIN_3V3_EN (0 + 13) // P0.13
85+
// #define PIN_3V3_EN (0 + 13) // P0.13
8686

8787
// Battery
8888
#define BATTERY_PIN (0 + 31) // P0.31
@@ -121,10 +121,10 @@ E22/NRF52 PRO MICRO PIN ASSIGNMENT
121121
#define BUTTON_PIN (-1) // no button
122122

123123
// GPS
124-
#define PIN_GPS_TX (32 + 1) // P1.01
124+
#define PIN_GPS_TX (32 + 7) // P1.07
125125
#define PIN_GPS_RX (32 + 2) // P1.02
126126

127-
#define PIN_GPS_EN (32 + 7) // P1.07
127+
#define PIN_GPS_EN (0 + 13) // P0.13 3.3V enable
128128
#define GPS_POWER_TOGGLE
129129
#define GPS_UBLOX
130130
// define GPS_DEBUG

0 commit comments

Comments
 (0)