Possible unintended discrepancy in rate limiting of "Adhoc Ping" #6442
Closed
todd-herbert
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
In the OLED UI, double pressing the user button sends an "adhoc ping". This is performed by
MeshService::trySendPosition
.If the node has a valid position, this ping takes the form of a position packet. If position is not known, the ping takes the form of a node info packet. It looks to me that, if the ping takes the form of a position packet, it can be sent as often as the user desires, but if it takes the form of a node info packet, it is subject to the usual five minute cool-down for node info broadcasts.
Is this rate-limiting discrepancy intentional?
Is there a desire to adjust the rate-limiting in some way to align the two cases?
Currently there is no feedback to a user when a ping is rejected, other than in the debug logs. Should the cool-down be indicated in some way?
Beta Was this translation helpful? Give feedback.
All reactions