DFROBOT_RAIN not sending telemetry

[deftdev]

So i have a RP2040Lora with a SHT40 and a DFROBOT_RAIN sensor hooked up.

Firmware 2.7.6 built with only a minor change to make the SHT40 work.

The serial console shows that it is detecting the sensor and reading the data, however it does not seem to send this over the network.
Is this something I need to configure elsewhere? or just not actually a feature despite it being listed as a compatible module?

Ive spent the last couple of days searching for any information on making the DFROBOT_RAIN work, however all I can see is a couple of posts saying it was supported from firmware 2.5.x and nothing about how to configure it

INFO | ??:??:?? 12 [EnvironmentTelemetry] Environment Telemetry: init
INFO | ??:??:?? 12 [EnvironmentTelemetry] Init sensor: DFROBOT_RAIN
INFO | ??:??:?? 12 [EnvironmentTelemetry] Opened DFROBOT_RAIN sensor on i2c bus
DEBUG | ??:??:?? 12 [EnvironmentTelemetry] DFROBOT_RAIN VID: 3343, PID: 100c0, Version: 1.0.0.0
INFO | ??:??:?? 12 [EnvironmentTelemetry] Init sensor: SHT4X
DEBUG | ??:??:?? 12 [EnvironmentTelemetry] serialNumber : 14abaa32
INFO | ??:??:?? 12 [EnvironmentTelemetry] Opened SHT4X sensor on i2c bus
......
INFO | ??:??:?? 88 [EnvironmentTelemetry] Rain 1h: 1.676400 mm
INFO | ??:??:?? 88 [EnvironmentTelemetry] Rain 24h: 1.676400 mm
INFO | ??:??:?? 88 [EnvironmentTelemetry] Send: barometric_pressure=0.000000, current=0.000000, gas_resistance=0.000000, relative_humidity=45.382851, temperature=22.019913
INFO | ??:??:?? 88 [EnvironmentTelemetry] Send: voltage=0.000000, IAQ=0, distance=0.000000, lux=0.000000
INFO | ??:??:?? 88 [EnvironmentTelemetry] Send: wind speed=0.000000m/s, direction=0 degrees, weight=0.000000kg
INFO | ??:??:?? 88 [EnvironmentTelemetry] Send: radiation=0.000000##R/h
INFO | ??:??:?? 88 [EnvironmentTelemetry] Send: soil_temperature=0.000000, soil_moisture=0
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] Partially randomized packet id 860208880
INFO | ??:??:?? 88 [EnvironmentTelemetry] Send packet to mesh
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] Update DB node 0x9f86352d, rx_time=0
INFO | ??:??:?? 88 [EnvironmentTelemetry] Sort took 0 milliseconds
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] handleReceived(LOCAL) (id=0x3345bef0 fr=0x9f86352d to=0xffffffff, transport = 0, WantAck=0, HopLim=7 Ch=0x0 Portnum=67 priority=10)
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] Calling specific module: routing
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] No modules interested in portnum=67, src=LOCAL
INFO | ??:??:?? 88 [EnvironmentTelemetry] Packet History - insert: Using new slot @uptime 88.266s TRACE NEW
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] Expand short PSK #1
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] Use AES128 key!
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] enqueue for send (id=0x3345bef0 fr=0x9f86352d to=0xffffffff, transport = 0, WantAck=0, HopLim=7 Ch=0x8 encrypted len=51 hopStart=7 relay=0x2d priority=10)
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] txGood=4,txRelay=2,rxGood=3,rxBad=0
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] Use channel 0 (hash 0x8)
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] Expand short PSK #1
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] Use AES128 key!
DEBUG | ??:??:?? 88 [EnvironmentTelemetry] decoded message (id=0x3345bef0 fr=0x9f86352d to=0xffffffff, transport = 0, WantAck=0, HopLim=7 Ch=0x0 Portnum=67 hopStart=7 relay=0x2d priority=10)

[deftdev]

So in case anyone else finds this, there is no actual support in the firmware to transmit the stats, however it does read the values to the log

I was able to make changes to the firmware to transmit the telemetry over the mesh, but I cannot get the app to show them, im guessing this will need to be either a change to the app itself or need to have the value names transmitted in a certain format?

Maybe someone more familiar with the code could let me know more about this?