Merge pull request #41 from meshtastic/fix-utoa-crash

Fix crash on startup in itoa.cpp

Author: mverch67

cores/portduino/itoa.cpp

@@ -1,20 +1,37 @@
-#include "itoa.h"
-#include <stdlib.h>
+#include <itoa.h>
+#include <string>
+#include <stdexcept>
+#include <stdio.h>
 
-// FIXME - implement this
 
-char *itoa(int value, char *string, int radix) {
-    return NULL;
+std::string radixToFmtString(int const radix)
+{
+    if (radix == 8)  return std::string("%o");
+    else if (radix == 10) return std::string("%d");
+    else if (radix == 16) return std::string("%X");
+    else throw std::runtime_error("Invalid radix.");
 }
 
-char *ltoa(long value, char *string, int radix) {
-    return NULL;
+char * itoa(int value, char * str, int radix)
+{
+    sprintf(str, radixToFmtString(radix).c_str(), value);
+    return str;
 }
 
-char *utoa(unsigned value, char *string, int radix) {
-    return NULL;
+char * ltoa(long value, char * str, int radix)
+{
+    sprintf(str, radixToFmtString(radix).c_str(), value);
+    return str;
 }
 
-char *ultoa(unsigned long value, char *string, int radix) {
-    return NULL;
-}
+char * utoa(unsigned value, char *str, int radix)
+{
+    sprintf(str, radixToFmtString(radix).c_str(), value);
+    return str;
+}
+
+char * ultoa(unsigned long value, char * str, int radix)
+{
+    sprintf(str, radixToFmtString(radix).c_str(), value);
+    return str;
+}