TST: adjust for changes in pyproject-metadata 0.9.0

Author: dnicolodi

pyproject.toml

@@ -47,6 +47,7 @@ dynamic = [
 [project.optional-dependencies]
 test = [
   'build',
+  'packaging >= 23.1',
   'pytest >= 6.0',
   'pytest-cov[toml]',
   'pytest-mock',

tests/conftest.py

@@ -16,6 +16,7 @@
 
 from venv import EnvBuilder
 
+import packaging.metadata
 import packaging.version
 import pytest
 
@@ -24,6 +25,12 @@
 from mesonpy._util import chdir
 
 
+def metadata(data):
+    meta, other = packaging.metadata.parse_email(data)
+    assert not other
+    return meta
+
+
 def adjust_packaging_platform_tag(platform: str) -> str:
     if platform.startswith(('manylinux', 'musllinux')):
         # The packaging module generates overly specific platforms tags on

tests/test_metadata.py

@@ -53,6 +53,8 @@ def test_missing_version(package_missing_version):
         re.escape('Required "project.version" field is missing'),
         # pyproject-metatadata 0.8.0 and later
         re.escape('Field "project.version" missing and "version" not specified in "project.dynamic"'),
+        # pyproject-metatadata 0.9.0 and later
+        re.escape('Field "project.version" missing and \'version\' not specified in "project.dynamic"'),
     ))
     with pytest.raises(pyproject_metadata.ConfigurationError, match=match):
         Metadata.from_pyproject(pyproject, pathlib.Path())

tests/test_sdist.py

@@ -4,7 +4,6 @@
 
 import os
 import pathlib
-import re
 import stat
 import sys
 import tarfile
@@ -15,41 +14,50 @@
 
 import mesonpy
 
-from .conftest import in_git_repo_context
+from .conftest import in_git_repo_context, metadata
 
 
 def test_no_pep621(sdist_library):
     with tarfile.open(sdist_library, 'r:gz') as sdist:
-        sdist_pkg_info = sdist.extractfile('library-1.0.0/PKG-INFO').read().decode()
+        sdist_pkg_info = sdist.extractfile('library-1.0.0/PKG-INFO').read()
 
-    assert sdist_pkg_info == textwrap.dedent('''\
+    assert metadata(sdist_pkg_info) == metadata(textwrap.dedent('''\
         Metadata-Version: 2.1
         Name: library
         Version: 1.0.0
-    ''')
+    '''))
 
 
 def test_pep621(sdist_full_metadata):
     with tarfile.open(sdist_full_metadata, 'r:gz') as sdist:
-        sdist_pkg_info = sdist.extractfile('full_metadata-1.2.3/PKG-INFO').read().decode()
+        sdist_pkg_info = sdist.extractfile('full_metadata-1.2.3/PKG-INFO').read()
+
+    meta = metadata(sdist_pkg_info)
+
+    # pyproject-metadata prior to 0.9.0 strips trailing newlines
+    meta['license'] = meta['license'].rstrip()
 
-    metadata = re.escape(textwrap.dedent('''\
+    # pyproject-metadata 0.9.0 and later does not emit Home-Page
+    meta.pop('home_page', None)
+    # nor normalizes Project-URL keys
+    meta['project_urls'] = {k.lower(): v for k, v in meta['project_urls'].items()}
+
+    assert meta == metadata(textwrap.dedent('''\
         Metadata-Version: 2.1
         Name: full-metadata
         Version: 1.2.3
         Summary: Some package with all of the PEP 621 metadata
-        Keywords: full metadata
-        Home-page: https://example.com
+        Keywords: full,metadata
         Author: Jane Doe
         Author-Email: Unknown <[email protected]>
         Maintainer-Email: Jane Doe <[email protected]>
         License: some license
         Classifier: Development Status :: 4 - Beta
         Classifier: Programming Language :: Python
-        Project-URL: Homepage, https://example.com
-        Project-URL: Documentation, https://readthedocs.org
-        Project-URL: Repository, https://github.com/mesonbuild/meson-python
-        Project-URL: Changelog, https://github.com/mesonbuild/meson-python/blob/master/CHANGELOG.rst
+        Project-URL: homepage, https://example.com
+        Project-URL: documentation, https://readthedocs.org
+        Project-URL: repository, https://github.com/mesonbuild/meson-python
+        Project-URL: changelog, https://github.com/mesonbuild/meson-python/blob/master/CHANGELOG.rst
         Requires-Python: >=3.7
         Requires-Dist: a
         Requires-Dist: b>1
@@ -70,20 +78,16 @@ def test_pep621(sdist_full_metadata):
         An example package with all of the PEP 621 metadata!
     '''))
 
-    # pyproject-metadata 0.8.0 and later uses a comma to separate keywords
-    expr = metadata.replace(r'Keywords:\ full\ metadata', r'Keywords:\ full[ ,]metadata')
-    assert re.fullmatch(expr, sdist_pkg_info)
-
 
 def test_dynamic_version(sdist_dynamic_version):
     with tarfile.open(sdist_dynamic_version, 'r:gz') as sdist:
-        sdist_pkg_info = sdist.extractfile('dynamic_version-1.0.0/PKG-INFO').read().decode()
+        sdist_pkg_info = sdist.extractfile('dynamic_version-1.0.0/PKG-INFO').read()
 
-    assert sdist_pkg_info == textwrap.dedent('''\
+    assert metadata(sdist_pkg_info) == metadata(textwrap.dedent('''\
         Metadata-Version: 2.1
         Name: dynamic-version
         Version: 1.0.0
-    ''')
+    '''))
 
 
 def test_contents(sdist_library):