Skip to content

Commit a0f0827

Browse files
dnicolodirgommers
authored andcommitted
TST: remove pep518 tests
These tests verify that build can build sdists and wheels using meson-python. The pep518 name is misleading as meson-python itself does not implement PEP 518. These tests verify that the PEP 517 hooks exported by meson-python work as build expects them to work. These tests setup a local directory with wheel for the build dependencies. This is problematic for two reasons: it requires network access, thus distributions need to disable these tests with downstream patches, and it makes it very difficult to run the tests against a specific version of meson. Creation of wheels and sdists is tested as part of the unit tests. The pep517 tests are unit tests for some of the PEP 517 hooks. The installation of meson-python itself in the CI jobs works as integration tests. Remove these tests.
1 parent f63c40b commit a0f0827

File tree

2 files changed

+0
-52
lines changed

2 files changed

+0
-52
lines changed

tests/conftest.py

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -152,25 +152,3 @@ def disable_pip_version_check():
152152
mpatch = pytest.MonkeyPatch()
153153
yield mpatch.setenv('PIP_DISABLE_PIP_VERSION_CHECK', '1')
154154
mpatch.undo()
155-
156-
157-
@pytest.fixture(scope='session')
158-
def pep518_wheelhouse(tmp_path_factory):
159-
wheelhouse = os.fspath(tmp_path_factory.mktemp('wheelhouse'))
160-
meson_python = os.fspath(package_dir.parent.parent)
161-
# Populate wheelhouse with wheel for the following packages and
162-
# their dependencies. Wheels are downloaded from PyPI or built
163-
# from the source distribution as needed. Sources or wheels in
164-
# the pip cache are used when available.
165-
packages = [
166-
meson_python,
167-
]
168-
cmd = [sys.executable, '-m', 'pip', 'wheel', '--no-build-isolation', '--wheel-dir', wheelhouse, *packages]
169-
subprocess.run(cmd, check=True)
170-
return wheelhouse
171-
172-
173-
@pytest.fixture
174-
def pep518(pep518_wheelhouse, monkeypatch):
175-
monkeypatch.setenv('PIP_FIND_LINKS', pep518_wheelhouse)
176-
monkeypatch.setenv('PIP_NO_INDEX', 'true')

tests/test_pep518.py

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)