TST: drop workaround for Cython bug fixed in version 0.29.34

Author: dnicolodi

tests/conftest.py

@@ -2,7 +2,6 @@
 #
 # SPDX-License-Identifier: MIT
 
-import atexit
 import contextlib
 import os
 import os.path
@@ -75,24 +74,6 @@ def tmp_path_session(tmp_path_factory):
     ))
 
 
-@pytest.fixture
-def tmp_build_path():
-    # Similar to the tmp_path fixture but ensures that the temporary
-    # directory is on the same Windows drive as the test packages
-    # source directory. This is required to work around a Cython bug
-    # exposed in our test packages. See https://github.com/cython/cython/pull/5279
-    tmpdir = tempfile.mkdtemp(prefix='.build-', dir=package_dir)
-    # The clenup is implemented with an atexit hook rather than with a
-    # regular context manager because we import extension modules from
-    # the build directory in the tests and these need to stay around
-    # till the Python interpreter is being teared down. Orherwise
-    # PermissionError removing the folder are obtained on Windows, but
-    # more importantly, the removal succeeds on Cygwin but memory
-    # mapping errors are obtained when Python tries to fork().
-    atexit.register(shutil.rmtree, tmpdir, ignore_errors=True)
-    yield pathlib.Path(tmpdir)
-
-
 class VEnv(EnvBuilder):
     def __init__(self, env_dir):
         super().__init__(with_pip=True)

tests/test_editable.py

@@ -58,10 +58,10 @@ def test_collect(package_complex):
     assert tree['complex']['more']['__init__.py'] == os.path.join(root, 'complex', 'more', '__init__.py')
 
 
-def test_mesonpy_meta_finder(package_complex, tmp_build_path):
+def test_mesonpy_meta_finder(package_complex, tmp_path):
     # build a package in a temporary directory
-    mesonpy.Project(package_complex, tmp_build_path)
-    build_path = tmp_build_path / 'build'
+    mesonpy.Project(package_complex, tmp_path)
+    build_path = tmp_path / 'build'
 
     # point the meta finder to the build directory
     finder = _editable.MesonpyMetaFinder({'complex'}, os.fspath(build_path), ['ninja'])