Skip to content

MAINT: improve error message when meson isn't found #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2024
Merged

MAINT: improve error message when meson isn't found #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion mesonpy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,8 @@ def _get_meson_command(
# directly. For packages that vendor a forked Meson, the `meson.py` in the
# root of the Meson repo can be used this way.
if meson.endswith('.py'):
if not os.path.exists(meson):
raise ConfigError(f'Could not find the specified meson: "{meson}"')
cmd = [sys.executable, meson]
else:
cmd = [meson]
Expand All @@ -997,7 +999,11 @@ def _get_meson_command(
# but the corresponding meson command is not available in $PATH. Implement
# a runtime check to verify that the build environment is setup correcly.
required_version = _parse_version_string(version)
meson_version = subprocess.run(cmd + ['--version'], check=False, text=True, capture_output=True).stdout
try:
meson_version = subprocess.run(cmd + ['--version'], check=False, text=True, capture_output=True).stdout
except FileNotFoundError as err:
raise ConfigError(f'meson executable "{meson}" not found') from err

if _parse_version_string(meson_version) < required_version:
raise ConfigError(f'Could not find meson version {version} or newer, found {meson_version}.')

Expand Down