MAINT: improve error reporting when meson --version fails
#633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
meson-version-check
branch
from
a756ee0 to
51125fd
Compare
rgommers
added
the
maintenance
rgommers
approved these changes
May 19, 2024
Contributor
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
LGTM, thanks @dnicolodi
| except FileNotFoundError as err: | ||
| raise ConfigError(f'meson executable "{meson}" not found') from err | ||
| if r.returncode != 0: | ||
| raise ConfigError(f'Could not execute meson: {r.stderr.strip()}') |
Contributor
There was a problem hiding this comment.
Good catch, stderr is correct here, stdout was not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #631