add free threading support to complex.extension #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the experimental free-threading Python version in the complex.extension module. closes mesonbuild#654
rgommers
added
the
maintenance
rgommers
approved these changes
Aug 2, 2024
Contributor
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
Thanks @jjhelmus! This LGTM.
This is the one extension module which is actually run, in test_editable.py. Other extension modules are only compiled and then the resulting wheel is inspected for correct tags etc., but the test suite does not emit warnings for them. So let's leave those alone. If this changes, the exact same fix can be applied to the other PyInit_*'s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the experimental free-threading Python version in the complex.extension module.
closes #654