minstall: allow missing symlink destination in install_symlink

Currently there's an undocumented behavior where using
`install_symlink()` to point to a file that does not exist results in
failure `ERROR: Tried to install symlink to missing file`.

Such behavior makes little sense because there's no reason the
destination file should exist. The "destination file" may belong to
another package, in particular to a package inside the same repo the
Meson is controlling, in both cases there's no reason the other
package should be present in the system, because installation does not
typically happen into the system but rather to DESTDIR. And the file
may not be present in DESTDIR either because it may belong to a
different installation target (and different DESTDIR) even if it's in
the same repo.

Best backward-compatible decision here would be to just remove the
check, which is done by this commit.

Fixes: #12253

Author: Hi-Angel

mesonbuild/backend/backends.py

@@ -177,7 +177,6 @@ class InstallSymlinkData:
     install_path: str
     subproject: str
     tag: T.Optional[str] = None
-    allow_missing: bool = False
 
 # cannot use dataclass here because "exclude" is out of order
 class SubdirInstallData(InstallDataBase):
@@ -1710,7 +1709,7 @@ def generate_target_install(self, d: InstallData) -> None:
 
                     for alias, to, tag in t.get_aliases():
                         alias = os.path.join(first_outdir, alias)
-                        s = InstallSymlinkData(to, alias, first_outdir, t.subproject, tag, allow_missing=True)
+                        s = InstallSymlinkData(to, alias, first_outdir, t.subproject, tag)
                         d.symlinks.append(s)
 
                     if isinstance(t, (build.SharedLibrary, build.SharedModule, build.Executable)):

mesonbuild/minstall.py

@@ -441,15 +441,13 @@ def do_copyfile(self, from_file: str, to_file: str,
         append_to_log(self.lf, to_file)
         return True
 
-    def do_symlink(self, target: str, link: str, destdir: str, full_dst_dir: str, allow_missing: bool) -> bool:
+    def do_symlink(self, target: str, link: str, destdir: str, full_dst_dir: str) -> bool:
         abs_target = target
         if not os.path.isabs(target):
             abs_target = os.path.join(full_dst_dir, target)
-        elif not os.path.exists(abs_target) and not allow_missing:
+        elif not os.path.exists(abs_target):
             abs_target = destdir_join(destdir, abs_target)
-        if not os.path.exists(abs_target) and not allow_missing:
-            raise MesonException(f'Tried to install symlink to missing file {abs_target}')
-        if os.path.exists(link):
+        if os.path.lexists(link):
             if not os.path.islink(link):
                 raise MesonException(f'Destination {link!r} already exists and is not a symlink')
             self.remove(link)
@@ -656,7 +654,7 @@ def install_symlinks(self, d: InstallData, dm: DirMaker, destdir: str, fullprefi
             full_dst_dir = get_destdir_path(destdir, fullprefix, s.install_path)
             full_link_name = get_destdir_path(destdir, fullprefix, s.name)
             dm.makedirs(full_dst_dir, exist_ok=True)
-            if self.do_symlink(s.target, full_link_name, destdir, full_dst_dir, s.allow_missing):
+            if self.do_symlink(s.target, full_link_name, destdir, full_dst_dir):
                 self.did_install_something = True
 
     def install_man(self, d: InstallData, dm: DirMaker, destdir: str, fullprefix: str) -> None: