Add section on modifying source archives to "Creating releases" page #12837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.52.0 is from 2019 and no longer relevant (even Debian stable is at >1.0 by now), so no need to still document `ninja dist`. And it's especially unhelpful since `ninja dist` doesn't support all the options discussed on this page for `meson dist`.
paugier
reviewed
Feb 10, 2024
| meson.add_dist_script('gen_somefile.py') | ||
| ``` | ||
|
|
||
| Dist scripts work for any supported VCS. In addition, if Git is used as the |
Contributor
There was a problem hiding this comment.
Note that this is not yet true (see #12829 (comment)). However, this should indeed be the case because the dist script mechanism is orthogonal to the specific VCS program.
Contributor
Author
There was a problem hiding this comment.
It will be true when gh-12840 lands, right? I left the text unchanged, counting on that. If not, I'm not sure what to change it too - there's also some amount of Subversion and Bazaar support, and I'm not sure about the status there. I imagine at least simple dist scripts (like rm a-file) work?
rgommers
force-pushed
the
doc-release-distscript
branch
from
0b74bb4 to
b1a5a9e
Compare
Contributor
Author
|
@eli-schwartz is this good to merge as is? I think we'd like to link to this doc page in mesonbuild/meson-python#587 or a follow-up docs PR, so it would be nice to get this in. |
Member
|
I've pinged Eli on Matrix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-12796
In addition, some minor maintenance on this page: clean up a duplicate sentence and an outdated
ninjadistmention (mentioningninjadistis unhelpful since it doesn't support all the options discussed on this page formeson dist).