-
Notifications
You must be signed in to change notification settings - Fork 3
Deprecate requirements.txt files #459
Copy link
Copy link
Open
Description
Come to think of it, what's the use case for these files now that we use
uvandpyproject.toml? Are we keepingrequirements.txtaround so the codebase remains pip-compatible for users who don't haveuvinstalled? If that's helpful for users, then it makes sense to keep them, otherwise we could consider deprecating them gradually.
Good point @rugeli! The requirements.txt files are not strictly necessary as pip install works with pyproject.toml. However, I think some of our docker workflow and CI uses the pip install workflow reading from the requirements files. How about this:
- Merge this PR for now to see if that addresses any of the reported dependabot dependency issues.
- We look for and update instances of
pip installfrom requirementes files in the codebase and in the CI to useuv syncorpip installfrompyproject.tomlinstead - We stop tracking the
requirements.txtfiles, and get rid of the automated action that exports them after dependencies change. - Update
README.mdto reflect the new installation instructions
Originally posted by @mogres in #458 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels