Skip to content

Commit 88ad799

Browse files
authored
Adding missing field in SMS API (#119)
* changed testdata messageObjectWithCreatedDatetime -> messageObjectWithScheduledDatetime * added missing fields * tests updated & added TestRead * update testdata * go version up * add read tests * add tests for Delete method * replace deprecated DialTLS with DialTLSContext * improve error_test * add GroupIds to messageRequest * add GroupIds to request and tests * remove bool in result of sms.Delete * update version to 8 * update client version
1 parent c3c2f72 commit 88ad799

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+375
-109
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
fail-fast: true
1313
matrix:
14-
go-version: [ 1.16.x, 1.17.x, 1.18.x]
14+
go-version: [ 1.16.x, 1.17.x, 1.18.x ]
1515

1616
name: Go ${{ matrix.go-version }}
1717

UPGRADING.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,3 +103,8 @@ So all imports of `go-rest-api` are replaced as `go-rest-api/v6`.
103103
## `v6.1.0` -> `v7.0.0`
104104
### Verify Recipient type
105105
As v7 introduces support for using the Verify API with email recipients, the `Verify.Recipient` field has been changed from to a string type.
106+
107+
## `v7.1.0` -> `v8.0.0`
108+
### Update SMS API
109+
Added [missed fields](https://github.com/messagebird/go-rest-api/pull/119/commits/f9331269238f1518dd35d798a0fbf251bb04bb62) in SMS API.
110+
Updated `sms.Delete` method so now in return only error or nil as result.

balance/balance.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package balance
33
import (
44
"net/http"
55

6-
messagebird "github.com/messagebird/go-rest-api/v7"
6+
messagebird "github.com/messagebird/go-rest-api/v8"
77
)
88

99
// Balance describes your balance information.

balance/balance_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import (
44
"net/http"
55
"testing"
66

7-
messagebird "github.com/messagebird/go-rest-api/v7"
8-
"github.com/messagebird/go-rest-api/v7/internal/mbtest"
7+
messagebird "github.com/messagebird/go-rest-api/v8"
8+
"github.com/messagebird/go-rest-api/v8/internal/mbtest"
99
"github.com/stretchr/testify/assert"
1010
)
1111

client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import (
2626

2727
const (
2828
// ClientVersion is used in User-Agent request header to provide server with API level.
29-
ClientVersion = "7.1.0"
29+
ClientVersion = "8.0.0"
3030

3131
// Endpoint points you to MessageBird REST API.
3232
Endpoint = "https://rest.messagebird.com"

contact/contact.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"strconv"
99
"time"
1010

11-
messagebird "github.com/messagebird/go-rest-api/v7"
11+
messagebird "github.com/messagebird/go-rest-api/v8"
1212
)
1313

1414
// Contact gets returned by the API.

contact/contact_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
"testing"
77
"time"
88

9-
"github.com/messagebird/go-rest-api/v7/internal/mbtest"
9+
"github.com/messagebird/go-rest-api/v8/internal/mbtest"
1010
)
1111

1212
func TestMain(m *testing.M) {

conversation/api.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77
"strconv"
88
"time"
99

10-
messagebird "github.com/messagebird/go-rest-api/v7"
10+
messagebird "github.com/messagebird/go-rest-api/v8"
1111
)
1212

1313
const (

conversation/conversation.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import (
44
"fmt"
55
"net/http"
66

7-
messagebird "github.com/messagebird/go-rest-api/v7"
7+
messagebird "github.com/messagebird/go-rest-api/v8"
88
)
99

1010
// ListOptions can be used to set pagination options in List().

conversation/conversation_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"testing"
66
"time"
77

8-
"github.com/messagebird/go-rest-api/v7/internal/mbtest"
8+
"github.com/messagebird/go-rest-api/v8/internal/mbtest"
99
"github.com/stretchr/testify/assert"
1010
)
1111

0 commit comments

Comments
 (0)