Use Path constants for URLs

Author: Dirk Hoekstra

client.go

@@ -33,6 +33,8 @@ const (
 	HLRPath = "hlr"
 	// MessagePath represents the path to the Message resource.
 	MessagePath = "messages"
+	// MMSPath represents the path to the MMS resource.
+	MMSPath = "mms"
 	// VoiceMessagePath represents the path to the VoiceMessage resource.
 	VoiceMessagePath = "voicemessages"
 	// VerifyPath represents the path to the Verify resource.
@@ -220,7 +222,7 @@ func (c *Client) Messages(msgListParams *MessageListParams) (*MessageList, error
 		return messageList, err
 	}
 
-	if err := c.request(messageList, "messages?"+params.Encode(), nil); err != nil {
+	if err := c.request(messageList, MessagePath+"?"+params.Encode(), nil); err != nil {
 		if err == ErrResponse {
 			return messageList, err
 		}
@@ -257,7 +259,7 @@ func (c *Client) NewMessage(originator string, recipients []string, body string,
 // MMSMessage retrieves the information of an existing MmsMessage.
 func (c *Client) MMSMessage(id string) (*MMSMessage, error) {
 	mmsMessage := &MMSMessage{}
-	if err := c.request(mmsMessage, "mms/"+id, nil); err != nil {
+	if err := c.request(mmsMessage, MMSPath+"/"+id, nil); err != nil {
 		if err == ErrResponse {
 			return mmsMessage, err
 		}
@@ -279,7 +281,7 @@ func (c *Client) NewMMSMessage(originator string, recipients []string, msgParams
 	params.Set("recipients", strings.Join(recipients, ","))
 
 	mmsMessage := &MMSMessage{}
-	if err := c.request(mmsMessage, "mms", params); err != nil {
+	if err := c.request(mmsMessage, MMSPath, params); err != nil {
 		if err == ErrResponse {
 			return mmsMessage, err
 		}
@@ -392,7 +394,7 @@ func (c *Client) Lookup(phoneNumber string, params *LookupParams) (*Lookup, erro
 // NewLookupHLR creates a new HLR lookup for the specified number.
 func (c *Client) NewLookupHLR(phoneNumber string, params *LookupParams) (*HLR, error) {
 	urlParams := paramsForLookup(params)
-	path := LookupPath + "/" + phoneNumber + "/hlr"
+	path := LookupPath + "/" + phoneNumber + "/" + HLRPath
 
 	hlr := &HLR{}
 	if err := c.request(hlr, path, urlParams); err != nil {
@@ -409,7 +411,7 @@ func (c *Client) NewLookupHLR(phoneNumber string, params *LookupParams) (*HLR, e
 // LookupHLR performs a HLR lookup for the specified number.
 func (c *Client) LookupHLR(phoneNumber string, params *LookupParams) (*HLR, error) {
 	urlParams := paramsForLookup(params)
-	path := LookupPath + "/" + phoneNumber + "/hlr?" + urlParams.Encode()
+	path := LookupPath + "/" + phoneNumber + "/" + HLRPath + "?" + urlParams.Encode()
 
 	hlr := &HLR{}
 	if err := c.request(hlr, path, nil); err != nil {