Changes after review

Author: romanyx

README.md

@@ -38,14 +38,14 @@ Now you can query the API for information or send data. For example, if we want
 // Request the balance information, returned as a Balance object.
 balance, err := client.Balance()
 if err != nil {
-  // messagebird.ErrResponse means custom JSON errors.
-  if err == messagebird.ErrResponse {
-    for _, mbError := range balance.Errors {
-      fmt.Printf("Error: %#v\n", mbError)
-    }
-  }
-
-  return
+	switch errResp := err.(type) {
+	case messagebird.ErrorResponse:
+		for _, mbError := range errResp.Errors {
+			fmt.Printf("Error: %#v\n", mbError)
+		}
+	}
+
+	return
 }
 
 fmt.Println("  payment :", balance.Payment)

balance.go

@@ -5,5 +5,4 @@ type Balance struct {
 	Payment string
 	Type    string
 	Amount  float32
-	Errors  []Error // Deprecated: errors now returned at ErrorResponse instance as error.
 }

client.go

@@ -72,12 +72,6 @@ func New(accessKey string) *Client {
 	}
 }
 
-// NewV2 creates a new MessageBird client object.
-// Deprecated: use New factory instead.
-func NewV2(accessKey string) *Client {
-	return New(accessKey)
-}
-
 // Request is for internal use only and unstable.
 func (c *Client) Request(v interface{}, method, path string, data interface{}) error {
 	if !strings.HasPrefix(path, "https://") && !strings.HasPrefix(path, "http://") {

error.go

@@ -1,6 +1,8 @@
 package messagebird
 
-import "fmt"
+const (
+	apiErrMessage = "The MessageBird API returned an error"
+)
 
 // Error holds details including error code, human readable description and optional parameter that is related to the error.
 type Error struct {
@@ -9,20 +11,17 @@ type Error struct {
 	Parameter   string
 }
 
+// Error implements error interface.
+func (e Error) Error() string {
+	return e.Description
+}
+
 // ErrorResponse represents errored API response.
 type ErrorResponse struct {
 	Errors []Error `json:"errors"`
 }
 
 // Error implements error interface.
 func (r ErrorResponse) Error() string {
-	eString := "API returned an error: "
-	for i, e := range r.Errors {
-		eString = eString + fmt.Sprintf("code: %d, description: %s, parameter: %s", e.Code, e.Description, e.Parameter)
-		if i < len(r.Errors)-1 {
-			eString = eString + ", "
-		}
-	}
-
-	return eString
+	return apiErrMessage
 }

error_test.go

@@ -17,7 +17,6 @@ type HLR struct {
 	Details         map[string]interface{}
 	CreatedDatetime *time.Time
 	StatusDatetime  *time.Time
-	Errors          []Error // Deprecated: errors now returned at ErrorResponse instance as error.
 }
 
 // HLRList represents a list of HLR requests.

hlr.go

@@ -29,7 +29,6 @@ type Message struct {
 	ScheduledDatetime *time.Time
 	CreatedDatetime   *time.Time
 	Recipients        Recipients
-	Errors            []Error // Deprecated: errors now returned at ErrorResponse instance as error.
 }
 
 // MessageList represents a list of Messages.

message.go

@@ -20,7 +20,6 @@ type MMSMessage struct {
 	ScheduledDatetime *time.Time
 	CreatedDatetime   *time.Time
 	Recipients        Recipients
-	Errors            []Error // Deprecated: errors now returned at ErrorResponse instance as error
 }
 
 // MMSMessageParams represents the parameters that can be supplied when creating

mms_message.go

@@ -94,8 +94,10 @@ func TestNewMMSMessage(t *testing.T) {
 	if mmsMessage.Recipients.Items[0].StatusDatetime == nil || mmsMessage.Recipients.Items[0].StatusDatetime.Format(time.RFC3339) != "2017-10-20T12:50:28Z" {
 		t.Errorf("Unexpected datetime status for mmsMessage recipient: %s", mmsMessage.Recipients.Items[0].StatusDatetime.Format(time.RFC3339))
 	}
-	if len(mmsMessage.Errors) != 0 {
-		t.Errorf("Unexpected number of errors in mmsMessage: %d", len(mmsMessage.Errors))
+
+	errorResponse, ok := err.(ErrorResponse)
+	if ok {
+		t.Errorf("Unexpected error returned with mmsMessage %#v", errorResponse)
 	}
 }
 

mms_message_test.go

@@ -15,7 +15,6 @@ type Verify struct {
 	CreatedDatetime    *time.Time
 	ValidUntilDatetime *time.Time
 	Recipient          int
-	Errors             []Error // Deprecated: errors now returned at ErrorResponse instance as error.
 }
 
 // VerifyParams handles optional verification parameters.