Skip to content

Commit a1491a3

Browse files
author
Dirk Hoekstra
committed
Fix mms uppercase syntax
1 parent b35d568 commit a1491a3

File tree

3 files changed

+21
-21
lines changed

3 files changed

+21
-21
lines changed

client.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,9 @@ func (c *Client) NewMessage(originator string, recipients []string, body string,
196196
return message, nil
197197
}
198198

199-
// MmsMessage retrieves the information of an existing MmsMessage.
200-
func (c *Client) MmsMessage(id string) (*MmsMessage, error) {
201-
mmsMessage := &MmsMessage{}
199+
// MMSMessage retrieves the information of an existing MmsMessage.
200+
func (c *Client) MMSMessage(id string) (*MMSMessage, error) {
201+
mmsMessage := &MMSMessage{}
202202
if err := c.request(mmsMessage, "mms/"+id, nil); err != nil {
203203
if err == ErrResponse {
204204
return mmsMessage, err
@@ -210,17 +210,17 @@ func (c *Client) MmsMessage(id string) (*MmsMessage, error) {
210210
return mmsMessage, nil
211211
}
212212

213-
// NewMmsMessage creates a new MMS message for one or more recipients.
214-
func (c *Client) NewMmsMessage(originator string, recipients []string, msgParams *MmsMessageParams) (*MmsMessage, error) {
215-
params, err := paramsForMmsMessage(msgParams)
213+
// NewMMSMessage creates a new MMS message for one or more recipients.
214+
func (c *Client) NewMMSMessage(originator string, recipients []string, msgParams *MMSMessageParams) (*MMSMessage, error) {
215+
params, err := paramsForMMSMessage(msgParams)
216216
if err != nil {
217217
return nil, err
218218
}
219219

220220
params.Set("originator", originator)
221221
params.Set("recipients", strings.Join(recipients, ","))
222222

223-
mmsMessage := &MmsMessage{}
223+
mmsMessage := &MMSMessage{}
224224
if err := c.request(mmsMessage, "mms", params); err != nil {
225225
if err == ErrResponse {
226226
return mmsMessage, err

mms_message.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import (
77
"time"
88
)
99

10-
// MmsMessage represents a MMS Message.
11-
type MmsMessage struct {
10+
// MMSMessage represents a MMS Message.
11+
type MMSMessage struct {
1212
ID string
1313
HRef string
1414
Direction string
@@ -23,19 +23,19 @@ type MmsMessage struct {
2323
Errors []Error
2424
}
2525

26-
// MmsMessageParams represents the parameters that can be supplied when creating
26+
// MMSMessageParams represents the parameters that can be supplied when creating
2727
// a request.
28-
type MmsMessageParams struct {
28+
type MMSMessageParams struct {
2929
Body string
3030
MediaUrls []string
3131
Subject string
3232
Reference string
3333
ScheduledDatetime time.Time
3434
}
3535

36-
// paramsForMessage converts the specified MmsMessageParams struct to a
36+
// paramsForMMSMessage converts the specified MMSMessageParams struct to a
3737
// url.Values pointer and returns it.
38-
func paramsForMmsMessage(params *MmsMessageParams) (*url.Values, error) {
38+
func paramsForMMSMessage(params *MMSMessageParams) (*url.Values, error) {
3939
urlParams := &url.Values{}
4040

4141
if params.Body == "" && params.MediaUrls == nil {

mms_message_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,17 @@ var mmsMessageObject = []byte(`{
3131
}
3232
}`)
3333

34-
func TestNewMmsMessage(t *testing.T) {
34+
func TestNewMMSMessage(t *testing.T) {
3535
SetServerResponse(200, mmsMessageObject)
3636

37-
params := &MmsMessageParams{
37+
params := &MMSMessageParams{
3838
Body: "Hello World",
3939
MediaUrls: []string{"http://w3.org/1.gif", "http://w3.org/2.gif"},
4040
Subject: "TestSubject",
4141
Reference: "TestReference",
4242
ScheduledDatetime: time.Now(),
4343
}
44-
mmsMessage, err := mbClient.NewMmsMessage("TestName", []string{"31612345678"}, params)
44+
mmsMessage, err := mbClient.NewMMSMessage("TestName", []string{"31612345678"}, params)
4545

4646
if err != nil {
4747
t.Fatalf("Didn't expect error while creating a new MMS message: %s", err)
@@ -99,17 +99,17 @@ func TestNewMmsMessage(t *testing.T) {
9999
}
100100
}
101101

102-
func TestNewMmsMessageError(t *testing.T) {
102+
func TestNewMMSMessageError(t *testing.T) {
103103
SetServerResponse(405, accessKeyErrorObject)
104104

105-
params := &MmsMessageParams{
105+
params := &MMSMessageParams{
106106
Body: "Hello World",
107107
MediaUrls: nil,
108108
Subject: "",
109109
Reference: "",
110110
ScheduledDatetime: time.Now(),
111111
}
112-
mmsMessage, err := mbClient.NewMmsMessage("TestName", []string{"31612345678"}, params)
112+
mmsMessage, err := mbClient.NewMMSMessage("TestName", []string{"31612345678"}, params)
113113

114114
if err != ErrResponse {
115115
t.Fatalf("Expected ErrResponse to be returned, instead I got %s", err)
@@ -126,14 +126,14 @@ func TestNewMmsMessageError(t *testing.T) {
126126
}
127127

128128
func TestNewMmsMessageWithEmptyParams(t *testing.T) {
129-
params := &MmsMessageParams{
129+
params := &MMSMessageParams{
130130
Body: "",
131131
MediaUrls: nil,
132132
Subject: "",
133133
Reference: "",
134134
ScheduledDatetime: time.Now(),
135135
}
136-
_, err := mbClient.NewMmsMessage("TestName", []string{"31612345678"}, params)
136+
_, err := mbClient.NewMMSMessage("TestName", []string{"31612345678"}, params)
137137

138138
if err == nil {
139139
t.Fatalf("Expected error to be returned, instead I got nil")

0 commit comments

Comments
 (0)