Fix InitiateCall

In addition, an integration test has been added.

Author: polyfloyd

voice/call.go

@@ -140,9 +140,13 @@ func InitiateCall(client *messagebird.Client, source, destination string, callfl
 		body.Webhook.URL = webhook.URL
 		body.Webhook.Token = webhook.Token
 	}
-	call := &Call{}
-	err := client.Request(call, http.MethodPost, apiRoot+"/calls/", body)
-	return call, err
+	var resp struct {
+		Data []Call `json:"data"`
+	}
+	if err := client.Request(&resp, http.MethodPost, apiRoot+"/calls", body); err != nil {
+		return nil, err
+	}
+	return &resp.Data[0], nil
 }
 
 // Delete deletes the Call.

voice/call_test.go

@@ -0,0 +1,33 @@
+package voice
+
+import (
+	"testing"
+	"time"
+)
+
+func TestInitiateCall(t *testing.T) {
+	client, ok := testClient(t)
+	if !ok {
+		t.SkipNow()
+	}
+
+	source, destination := "31000000000", "31000000000"
+	callflow := CallFlow{
+		Title: "Say test",
+		Steps: []CallFlowStep{
+			&CallFlowSayStep{
+				Voice:    "male",
+				Payload:  "You are about to experience a great adventure which reaches from the inner mind to the outer limits",
+				Language: "en-US",
+			},
+			&CallFlowPauseStep{
+				Length: time.Second,
+			},
+			&CallFlowHangupStep{},
+		},
+	}
+	_, err := InitiateCall(client, source, destination, callflow, nil)
+	if err != nil {
+		t.Fatal(err)
+	}
+}

voice/callflow_test.go

@@ -131,7 +131,7 @@ func TestCallFlowJSONUnmarshal(t *testing.T) {
 }
 
 func TestCreateCallFlow(t *testing.T) {
-	mbClient, stop := testClient(http.StatusOK, []byte(`{
+	mbClient, stop := testRequest(http.StatusOK, []byte(`{
 		"data": [
 			{
 				"id": "the-id",

voice/main_test.go

@@ -12,7 +12,7 @@ import (
 	"github.com/messagebird/go-rest-api"
 )
 
-func testClient(status int, body []byte) (*messagebird.Client, func()) {
+func testRequest(status int, body []byte) (*messagebird.Client, func()) {
 	mbServer := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(status)
@@ -33,3 +33,25 @@ func testClient(status int, body []byte) (*messagebird.Client, func()) {
 	}
 	return mbClient, func() { mbServer.Close() }
 }
+
+func testClient(t *testing.T) (*messagebird.Client, bool) {
+	key, ok := os.LookupEnv("MB_TEST_KEY")
+	if !ok {
+		return nil, false
+	}
+	client := &messagebird.Client{
+		AccessKey:  key,
+		HTTPClient: &http.Client{},
+		DebugLog:   log.New(testWriter{T: t}, "", 0),
+	}
+	return client, true
+}
+
+type testWriter struct {
+	T *testing.T
+}
+
+func (tw testWriter) Write(b []byte) (int, error) {
+	tw.T.Logf("%s", b)
+	return len(b), nil
+}

voice/paginator_test.go

@@ -10,7 +10,7 @@ func TestPaginatorStream(t *testing.T) {
 	type myStruct struct {
 		Val int
 	}
-	mbClient, stop := testClient(http.StatusOK, []byte(`{
+	mbClient, stop := testRequest(http.StatusOK, []byte(`{
 		"data": [
 			{ "Val": 1 },
 			{ "Val": 2 },

voice/recording_test.go

@@ -8,7 +8,7 @@ import (
 
 func TestRecordingGetFile(t *testing.T) {
 	fileContents := []byte("this is not really a WAV file")
-	mbClient, stop := testClient(http.StatusOK, []byte(fileContents))
+	mbClient, stop := testRequest(http.StatusOK, []byte(fileContents))
 	defer stop()
 
 	rec := &Recording{

voice/transcription_test.go

@@ -7,7 +7,7 @@ import (
 
 func TestTranscriptionGetContents(t *testing.T) {
 	text := "the quick brown fox jumps over the lazy dog"
-	mbClient, stop := testClient(http.StatusOK, []byte(text))
+	mbClient, stop := testRequest(http.StatusOK, []byte(text))
 	defer stop()
 
 	trans := &Transcription{