Merge pull request #78 from guilhermehubner/read-recording

feat(voice) implementing read recording

Author: sbogx

voice/recording.go

@@ -66,30 +66,34 @@ type jsonRecording struct {
 	Links     map[string]string `json:"_links"`
 }
 
+// ReadRecording fetches a single Recording based on its call ID, leg ID and the recording ID.
+func ReadRecording(c *messagebird.Client, callID, legID, id string) (*Recording, error) {
+	json := new(struct {
+		Data []*Recording `json:"data"`
+	})
+
+	if err := c.Request(json, http.MethodGet, fmt.Sprintf("%s/v1/calls/%s/legs/%s/recordings/%s",
+		apiRoot, callID, legID, id), nil); err != nil {
+		return nil, err
+	}
+
+	return json.Data[0], nil
+}
+
 // UnmarshalJSON implements the json.Unmarshaler interface.
 func (rec *Recording) UnmarshalJSON(data []byte) error {
-	var raw jsonRecording
-	if err := json.Unmarshal(data, &raw); err != nil {
+	recording := new(jsonRecording)
+
+	if err := json.Unmarshal(data, recording); err != nil {
 		return err
 	}
-	createdAt, err := time.Parse(time.RFC3339, raw.CreatedAt)
-	if err != nil {
-		return fmt.Errorf("unable to parse Recording CreatedAt: %v", err)
-	}
-	updatedAt, err := time.Parse(time.RFC3339, raw.UpdatedAt)
+
+	r, err := parseJSON(recording)
 	if err != nil {
-		return fmt.Errorf("unable to parse Recording UpdatedAt: %v", err)
-	}
-	*rec = Recording{
-		ID:        raw.ID,
-		Format:    raw.Format,
-		LegID:     raw.LegID,
-		Status:    RecordingStatus(raw.Status),
-		Duration:  time.Second * time.Duration(raw.Duration),
-		CreatedAt: createdAt,
-		UpdatedAt: updatedAt,
-		Links:     raw.Links,
+		return err
 	}
+
+	*rec = *r
 	return nil
 }
 
@@ -118,3 +122,25 @@ func (rec *Recording) DownloadFile(client *messagebird.Client) (io.ReadCloser, e
 	}
 	return resp.Body, nil
 }
+
+func parseJSON(recording *jsonRecording) (*Recording, error) {
+	createdAt, err := time.Parse(time.RFC3339, recording.CreatedAt)
+	if err != nil {
+		return nil, fmt.Errorf("unable to parse Recording CreatedAt: %v", err)
+	}
+	updatedAt, err := time.Parse(time.RFC3339, recording.UpdatedAt)
+	if err != nil {
+		return nil, fmt.Errorf("unable to parse Recording UpdatedAt: %v", err)
+	}
+
+	return &Recording{
+		ID:        recording.ID,
+		Format:    recording.Format,
+		LegID:     recording.LegID,
+		Status:    RecordingStatus(recording.Status),
+		Duration:  time.Second * time.Duration(recording.Duration),
+		CreatedAt: createdAt,
+		UpdatedAt: updatedAt,
+		Links:     recording.Links,
+	}, nil
+}

voice/recording_test.go

@@ -4,6 +4,8 @@ import (
 	"io/ioutil"
 	"net/http"
 	"testing"
+
+	"github.com/messagebird/go-rest-api/internal/mbtest"
 )
 
 func TestRecordingGetFile(t *testing.T) {
@@ -31,3 +33,25 @@ func TestRecordingGetFile(t *testing.T) {
 		t.Fatalf("mismatched downloaded contents")
 	}
 }
+
+func TestReadRecording(t *testing.T) {
+	mbtest.WillReturnTestdata(t, "recordingObject.json", http.StatusOK)
+	client := mbtest.Client(t)
+
+	recording, err := ReadRecording(client, "callid", "legid", "recid")
+	if err != nil {
+		t.Fatalf("unexpected error read recording: %s", err)
+	}
+
+	if recording.ID != "recid" {
+		t.Fatalf("expect %s got %s", "recid", recording.ID)
+	}
+	if recording.LegID != "legid" {
+		t.Fatalf("expect %s got %s", "legid", recording.LegID)
+	}
+	if recording.Status != RecordingStatusDone {
+		t.Fatalf("expect %s got %s", RecordingStatusDone, recording.Status)
+	}
+
+	mbtest.AssertEndpointCalled(t, http.MethodGet, "/v1/calls/callid/legs/legid/recordings/recid")
+}

voice/testdata/recordingObject.json

@@ -0,0 +1,23 @@
+{
+  "_links": {
+    "self": "/calls/callid/legs/legid/recordings/recid",
+    "transcriptions": "/calls/callid/legs/legid/recordings/recid/transcriptions?page=1"
+  },
+  "data": [
+    {
+      "id": "recid",
+      "format": "wav",
+      "legId": "legid",
+      "status": "done",
+      "duration": 6,
+      "type": "call",
+      "createdAt": "2020-03-10T13:11:31Z",
+      "updatedAt": "2020-03-10T13:11:38Z",
+      "deletedAt": null,
+      "_links": {
+        "file": "/recordings/recid.wav",
+        "self": "/recordings/recid"
+      }
+    }
+  ]
+}