Merge pull request #25 from messerli-informatik-ag/allow-validation-for-parameterless-routes

Allow validation for parameterless routes

Author: dngroth

Routing.Test/RoutingTest.cs

@@ -359,13 +359,10 @@ public void CallsFallbackWhenRoutingInvalidRouteParam(string param)
         }
 
         [Fact]
-        public void ThrowsWhenValidatingRouteWithNoParameters()
+        public void AllowValidatingRouteWithNoParameters()
         {
             var routeRegistry = CreateRouteRegistry();
-            var exception = Assert.Throws<ArgumentException>(() =>
-                routeRegistry.Register(new Endpoint(HttpMethod.Get, RegisteredRoute), FailOnRequest, FailOnValidation));
-
-            Assert.Null(exception.InnerException);
+            routeRegistry.Register(new Endpoint(HttpMethod.Get, RegisteredRoute), FailOnRequest, EmptyValidation);
         }
 
         [Fact]
@@ -498,6 +495,10 @@ private static Unit FailOnRequest(Unit request, IDictionary<string, string> rout
             throw new InvalidOperationException("Request handler was unexpectedly called");
         }
 
+        private static void EmptyValidation(IEnumerable<string> parameters)
+        {
+        }
+
         private static void FailOnValidation(IEnumerable<string> parameters)
         {
             throw new InvalidOperationException("Parameter validation has failed");

Routing/Routing.csproj

@@ -8,7 +8,7 @@
         <GenerateDocumentationFile>true</GenerateDocumentationFile>
         <AssemblyName>Messerli.Routing</AssemblyName>
         <RootNamespace>Messerli.Routing</RootNamespace>
-        <Version>0.3.1</Version>
+        <Version>0.3.2</Version>
         <RepositoryUrl>https://github.com/messerli-informatik-ag/routing</RepositoryUrl>
         <RepositoryType>git</RepositoryType>
         <PackageId>Messerli.Routing</PackageId>

Routing/SegmentRegistryFacadeImplementation/RouteRegistrar.cs

@@ -81,12 +81,6 @@ private static void RunParameterKeyValidation(ValidateParameterKeys validatePara
                 .Select(parameter => parameter.Key)
                 .ToList();
 
-            if (!parameters.Any())
-            {
-                throw new ArgumentException(
-                    "Passing a parameter validation callback to the registration of a route with no parameters is useless.");
-            }
-
             try
             {
                 validateParameterKeys(parameters);

Routing/changelog.md

@@ -13,3 +13,6 @@
 
 ## 0.3.1
 - Update to Funcky 2.0.0.
+
+## 0.3.2
+- Allow validation for parameterless routes