Skip to content

Commit 131d717

Browse files
msaroufimfacebook-github-bot
authored andcommitted
Modernize Build System (#12)
Summary: setup.py is kinda ancient and this is a newer library so can use more modern tooling Tested locally by running `pip install .`and `uv pip install .` Pull Request resolved: #12 Reviewed By: zonglinpeng Differential Revision: D79286538 Pulled By: manuelcandales fbshipit-source-id: 45392d4f935e5394fa9c908f3d7cf8412ecabf68
1 parent 7a929a6 commit 131d717

File tree

5 files changed

+31
-25
lines changed

5 files changed

+31
-25
lines changed

.github/workflows/python-app.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@ jobs:
2323
with:
2424
python-version: "3.10"
2525

26-
- name: Install dependencies
26+
- name: Install package and dependencies
2727
run: |
28-
python -m pip install --upgrade pip
29-
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
28+
pip install .
3029
3130
- name: Run tests
3231
run: |

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ Here is an [overview](facto/inputgen/overview.md) of InputGen
1818
SpecDB is a [database](facto/specdb/db.py#L30) of specifications covering most of the Core ATen Ops. They have been developed using the ATen CPU kernels as a reference.
1919

2020
## Instalation
21-
```
21+
```bash
2222
git clone https://github.com/pytorch-labs/FACTO.git
2323
cd FACTO
24-
python3 setup.py install
24+
pip install .
2525
```
2626

2727
## Example Usage

pyproject.toml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
[build-system]
2+
requires = ["setuptools>=45", "wheel"]
3+
build-backend = "setuptools.build_meta"
4+
5+
[project]
6+
name = "facto"
7+
version = "0.1.0"
8+
authors = [
9+
{name = "Manuel Candales"}
10+
]
11+
description = "Framework for Algorithmic Correctness Testing of Operators"
12+
readme = "README.md"
13+
requires-python = ">=3.8"
14+
classifiers = [
15+
"Programming Language :: Python :: 3",
16+
"License :: OSI Approved :: BSD 3-Clause License",
17+
"Operating System :: OS Independent",
18+
]
19+
dependencies = [
20+
"torch"
21+
]
22+
23+
[project.urls]
24+
Homepage = "https://github.com/pytorch-labs/FACTO"
25+
26+
[tool.setuptools.packages.find]
27+
include = ["facto", "facto.*"]

requirements.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

setup.py

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)