Skip to content

Commit 2326a98

Browse files
saitcakmakfacebook-github-bot
authored andcommitted
Swap the order of Ax and BoTorch installation in tutorials workflow (#1483)
Summary: Without this, Ax installation step would install BoTorch from PyPI, which would ignore the `ALLOW_LATEST_GPYTORCH_LINOP` env var. Pull Request resolved: #1483 Test Plan: Imported from GitHub, without a `Test Plan:` line. https://github.com/pytorch/botorch/actions/runs/3415873623/jobs/5685450129 installs dev version of linear operator, and this never gets overwritten. Reviewed By: SebastianAment Differential Revision: D41109511 Pulled By: saitcakmak fbshipit-source-id: 3290a66fbdc4c980e5d0eb2fc5de8f7853301344
1 parent 5ab36b1 commit 2326a98

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

.github/workflows/reusable_tutorials.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,26 +43,24 @@ jobs:
4343
min_torch_version=$(grep '\btorch>=' ${req_txt} | sed 's/[^0-9.]//g')
4444
min_gpytorch_version=$(grep '\bgpytorch>=' ${req_txt} | sed 's/[^0-9.]//g')
4545
pip install "torch==${min_torch_version}" "gpytorch==${min_gpytorch_version}" torchvision
46+
- name: Install BoTorch with tutorials dependencies
47+
env:
48+
ALLOW_LATEST_GPYTORCH_LINOP: true
49+
run: |
50+
pip install .[tutorials]
4651
- if: ${{ !inputs.use_stable_ax }}
4752
name: Install latest Ax
4853
env:
4954
# This is so Ax's setup doesn't install a pinned BoTorch version.
5055
ALLOW_BOTORCH_LATEST: true
51-
ALLOW_LATEST_GPYTORCH_LINOP: true
5256
run: |
5357
pip install git+https://github.com/facebook/Ax.git
5458
- if: ${{ inputs.use_stable_ax }}
5559
name: Install stable Ax
5660
env:
5761
ALLOW_BOTORCH_LATEST: true
58-
ALLOW_LATEST_GPYTORCH_LINOP: true
5962
run: |
6063
pip install ax-platform --no-binary ax-platform
61-
- name: Install BoTorch with tutorials dependencies
62-
env:
63-
ALLOW_LATEST_GPYTORCH_LINOP: true
64-
run: |
65-
pip install .[tutorials]
6664
- if: ${{ inputs.smoke_test }}
6765
name: Run tutorials with smoke test
6866
run: |

0 commit comments

Comments
 (0)