Skip to content

Commit 403d8ea

Browse files
saitcakmakfacebook-github-bot
authored andcommitted
Add test for GaussianMixturePosterior.mixture_covariance_matrix (#2314)
Summary: This was only being tested as part of `test_community`, which does not count for coverage of `botorch` after #2313. Adding a simple test to bump coverage. Pull Request resolved: #2314 Reviewed By: Balandat Differential Revision: D56724143 Pulled By: saitcakmak fbshipit-source-id: f5b25f8fa0393f0911b5ded3728c4d35f3a1f45c
1 parent e3dd9dd commit 403d8ea

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

test/models/test_fully_bayesian.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,14 +274,20 @@ def test_fit_model(self):
274274
mean, var = posterior.mean, posterior.variance
275275
self.assertEqual(mean.shape, expected_shape)
276276
self.assertEqual(var.shape, expected_shape)
277-
# Mixture mean/variance/median/quantiles
277+
# Mixture mean/variance/covariance/median/quantiles
278278
mixture_mean = posterior.mixture_mean
279279
mixture_variance = posterior.mixture_variance
280+
mixture_covariance = posterior.mixture_covariance_matrix
280281
quantile1 = posterior.quantile(value=torch.tensor(0.01))
281282
quantile2 = posterior.quantile(value=torch.tensor(0.99))
282283
self.assertEqual(mixture_mean.shape, torch.Size(batch_shape + [1]))
283284
self.assertEqual(mixture_variance.shape, torch.Size(batch_shape + [1]))
284285
self.assertTrue(mixture_variance.min() > 0.0)
286+
self.assertEqual(
287+
mixture_covariance.shape, torch.Size(batch_shape + batch_shape[-1:])
288+
)
289+
# Check that it is PSD.
290+
torch.linalg.cholesky(mixture_covariance.to_dense())
285291
self.assertEqual(quantile1.shape, torch.Size(batch_shape + [1]))
286292
self.assertEqual(quantile2.shape, torch.Size(batch_shape + [1]))
287293
self.assertTrue((quantile2 > quantile1).all())

0 commit comments

Comments
 (0)