Skip to content

Commit 4445045

Browse files
ItsMrLinfacebook-github-bot
authored andcommitted
Fix EUBO optimization error when two Xs are identical (#1670)
Summary: Pull Request resolved: #1670 Fixing 0/0 problem in EUBO when the two Xs are identical Reviewed By: qingfeng10 Differential Revision: D43204789 fbshipit-source-id: b53c8a811d0573db18f2082053242046427088b7
1 parent aa38ac4 commit 4445045

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

botorch/acquisition/preference.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
from botorch.utils.transforms import match_batch_shape, t_batch_mode_transform
2727
from torch import Tensor
2828

29+
SIGMA_JITTER = 1e-8
30+
2931

3032
class AnalyticExpectedUtilityOfBestOption(AnalyticAcquisitionFunction):
3133
r"""Analytic Prefential Expected Utility of Best Options, i.e., Analytical EUBO"""
@@ -102,7 +104,9 @@ def forward(self, X: Tensor) -> Tensor:
102104
+ pref_cov[..., 1, 1]
103105
- pref_cov[..., 0, 1]
104106
- pref_cov[..., 1, 0]
107+
+ SIGMA_JITTER
105108
)
109+
106110
u = delta / sigma
107111

108112
ucdf = self.std_norm.cdf(u)

0 commit comments

Comments
 (0)